[lldb-dev] [PATCH] Fix compile warnings with Platform::GetFile

[Greg Clayton]

Looks good.

On Jan 17, 2014, at 7:33 AM, Steve Pucci <spucci at google.com> wrote:

> Forgot to reply all:
> 
> ---------- Forwarded message ----------
> From: Steve Pucci <spucci at google.com>
> Date: Fri, Jan 17, 2014 at 7:32 AM
> Subject: Re: [lldb-dev] [PATCH] Fix compile warnings with Platform::GetFile
> To: Sylvestre Ledru <sylvestre at debian.org>
> 
> 
> This is the first piece of the separation of the previously submitted patch.  Notes for this piece (copied from previous email):
> 
> The rename of Platform::GetFile (the three-argument version) to GetFileWithUUID was suggested by gclayton as a way to silence gcc warnings; the warning is emitted when there is an overloaded function in a base class (Platform) for which a derived class redefines one of the overloads but not the other (because doing so hides the other overload from users of the derived class).  By giving the two methods different names, the situation is avoided.
> 
> Compiled and passed lldb tests on Linux Ubuntu 12.04 and gcc 4.8.2.
> 
> Thanks,
>    Steve
> 
> 
> <patch-warnings-GetFile.txt>_______________________________________________
> lldb-dev mailing list
> lldb-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev