[lldb-dev] [Patch] break-insert command in lldb-mi

[Zachary Turner]

Are all the changes localized to lldb-mi or do they trickle down into other
areas of LLDB?  If the latter, it would be nice if there were a way to
split them out into separate changelists.  Otherwise I suspect it will be a
difficult merge, and likely to stomp some other stuff that has gone in
since the commit activity has picked up recently.


On Thu, Aug 7, 2014 at 10:30 AM, Deepak Panickal <deepak at codeplay.com>
wrote:

> Hi Abid,
>
> I actually had a bunch of fixes and new features to upstream for lldb-mi,
> which I plan to do tomorrow.
> Could you please hold off committing this patch till then?
>
> Thanks,
> Deepak
>
>
> On 07/08/2014 18:19, Abid, Hafiz wrote:
>
>> Hi Deepak,
>> I was testing lldb-mi and I found a few issues with the break-insert
>> command.
>>
>> 1. The constructor of CMICmdArgValString used in this command did not
>> provide an option to set m_bHandleDirPaths. So the parsing will fail on
>> command like "26-break-insert --thread-group i1 -f
>> /home/abidh/demos/main.c:22". I added another parameter to the constructor
>> to solve this issue.
>>
>> 2. The parameter -f does not take any argument. The code was thinking
>> that it takes one which was causing an error.
>>
>> After these changes the break-insert command is working fine for me.
>> Please let me know if you see any problem with these change. Otherwise I
>> will apply them.
>>
>> Thanks,
>> Abid
>>
>
> _______________________________________________
> lldb-dev mailing list
> lldb-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20140807/6a4f5a0e/attachment.html>