[lldb-dev] PATCH for REVIEW: Move RegisterContextPOSIX to RegisterContextPOSIXProcessMonitor

[Greg Clayton]

The only thing I can think of is "RegisterContextPOSIX" now is just a mix-in protocol class and since it doesn't inherit from RegisterContext anymore, it might be better named something else? Maybe "POSIXBreakpointProtocol"?

Other than that, it looks good.

On Sep 13, 2013, at 2:51 PM, Michael Sartain <mikesart at gmail.com> wrote:

> Bit more RegisterContextPOSIX cleanup. This moves the RegisterContextPOSIX class to pure virtual and scoots it over directly to the RegisterContextPOSIXProcessMonitor classes. and removes it from the RegisterContextPOSIXCore classes which don't use any of those functions. All that RegisterContextPOSIX breakpoint code gets moved to the ProcessMonitor classes also.
> 
> http://llvm-reviews.chandlerc.com/D1681
> 
> Thanks!
>  -Mike
> 
> ---------- Forwarded message ----------
> From: Michael Sartain <mikesart at gmail.com>
> Date: Fri, Sep 13, 2013 at 2:47 PM
> Subject: [PATCH] Move RegisterContextPOSIX over to RegisterContextPOSIXProcessMonitor class. This cleans up RegisterContextPOSIXCore which doesn't use those functions.
> To: mikesart at gmail.com
> 
> 
> http://llvm-reviews.chandlerc.com/D1681
> 
> Files:
>   source/Plugins/Process/POSIX/POSIXThread.cpp
>   source/Plugins/Process/POSIX/POSIXThread.h
>   source/Plugins/Process/POSIX/RegisterContextPOSIX.h
>   source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_i386.h
>   source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_x86_64.cpp
>   source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_x86_64.h
>   source/Plugins/Process/POSIX/RegisterContextPOSIX_i386.cpp
>   source/Plugins/Process/POSIX/RegisterContextPOSIX_i386.h
>   source/Plugins/Process/POSIX/RegisterContextPOSIX_x86_64.cpp
>   source/Plugins/Process/POSIX/RegisterContextPOSIX_x86_64.h
>   source/Plugins/Process/elf-core/RegisterContextPOSIXCore_x86_64.cpp
>   source/Plugins/Process/elf-core/RegisterContextPOSIXCore_x86_64.h
> 
> _______________________________________________
> lldb-dev mailing list
> lldb-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev