[lldb-dev] [PATCH] Fix for ObjectFilePECOFF::GetArchitecture

Colin Riley colin at codeplay.com
Fri Nov 22 01:35:38 PST 2013

Thanks for the quick reply. There doesn't seem to be anything requiring 
it be 0 in ArchSpec; LLDB_INVALID_CPUTYPE is actually 0xFFFFFFFEu. In 
fact the coff entries in ArchSpec use LLDB_INVALID_CPUTYPE, so I think 
this is correct. I'll commit.

On 21/11/2013 23:24, Greg Clayton wrote:
> Looks good. Just make sure there isn't a take in ArchSpec.cpp that converts COFF cpu type/subtype that relies on the value being 0 instead of LLDB_INVALID_CPUTYPE (I also can't remember if LLDB_INVALID_CPUTYPE is zero?).
> On Nov 21, 2013, at 2:30 PM, Colin Riley <colin at codeplay.com> wrote:
>> <ObjectFilePECOFF.cpp.patch>

Colin Riley

Codeplay Software Ltd
45 York Place, Edinburgh, EH1 3HP
Phone: +44 131 466 0503
Fax: +44 131 557 6600
Website: http://www.codeplay.com
Twitter: @codeplaysoft

This email and any attachments may contain confidential and /or privileged information and  is for use  by the addressee only. If you are not the intended recipient, please notify Codeplay Software Ltd immediately and delete the message from your computer. You may not copy or forward it,or use or disclose its contents to any other person. Any views or other information in this message which do not relate to our business are not authorized by Codeplay software Ltd, nor does this message form part of any contract unless so stated.
As internet communications are capable of data corruption Codeplay Software Ltd does not accept any responsibility for any changes made to this message after it was sent. Please note that Codeplay Software Ltd does not accept any liability or responsibility for viruses and it is your responsibility to scan any attachments.
Company registered in England and Wales, number: 04567874
Registered office: 81 Linkfield Street, Redhill RH1 6BY

More information about the lldb-dev mailing list