[lldb-dev] Compile failure on FreeBSD

[Malea, Daniel]

Thanks Dimitry; replaced with a C-style include, in 183039!

Cheers,
Dan

On 2013-05-31 4:17 PM, "Dimitry Andric" <dimitry at andric.com> wrote:

>On May 31, 2013, at 21:06, Ed Maste <emaste at freebsd.org> wrote:
>> I'm trying to build lldb on FreeBSD (stable/9) using the system's
>> clang 3.2 and libc++, and have run into a couple of small nits along
>> the way.  This is at llvm svn r183025.
>> 
>> 1) Missing header for free() def'n (perhaps it leaks in from string.h
>> on other platforms).  On a quick glance I'm not sure string.h is even
>> needed.
>> 
>> Index: source/Core/Mangled.cpp
>> ===================================================================
>> --- source/Core/Mangled.cpp     (revision 183025)
>> +++ source/Core/Mangled.cpp     (working copy)
>> @@ -30,6 +30,7 @@
>>  #include "lldb/Core/Timer.h"
>>  #include <ctype.h>
>>  #include <string.h>
>> +#include <cstdlib>
>
>Just a nit: the other headers are old-style .h files, but then you
>include C++-style <cstdlib>.  Maybe it is more consistent to use
><stdlib.h> here?  I am not sure what the overall lldb convention is,
>though.
>
>Btw, really nice that you can spend some time on lldb for FreeBSD. :-)
>
>-Dimitry
>
>_______________________________________________
>lldb-dev mailing list
>lldb-dev at cs.uiuc.edu
>http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev