[lldb-dev] Patch for Review: Fix source list with symbol aliases

[jingham at apple.com]

That looks okay.  

The functions you added to CommandObjectSource (FindMatchingFunctions and FindMatchingFunctionSymbols) aren't really particular to CommandObjectSource, leading one to wonder if there were a better place to put them so they could be reused.  IIUC their job is "take a possibly empty vector of strings which are names of modules, and run the two search functions on the subset of the full module list that matches the strings in the input vector".  If we wanted to put them somewhere, there should probably be a module-filter-list that can be passed to the various ModuleList::Find* calls, which would either be a vector of string names or a ModuleSpecList.  We don't do anything like that at present.

Cooking that up seems like a lot of trouble right now.  We can probably hold off on that, but if we see this sort of construct getting used in other places, we should add such API's to ModuleList.

Jim


On Jul 10, 2013, at 1:49 PM, Michael Sartain <mikesart at gmail.com> wrote:

> On Wed, Jul 10, 2013 at 12:14 PM, <jingham at apple.com> wrote:
> That seems reasonable.  It should be simple, except there's a bunch of work we need to do to do fuzzy name matches (like folks expect if they look up foo::bar by name, it should match blah::foo::bar, etc.  So encapsulating that for symbols makes sense as it does with functions.  The FindFunctions with include_symbols=true is a separate thing, because it also does the work of coalescing symbols and functions so you don't end up with two copies of the same thing.
> 
> How does this look?
> 
> http://llvm-reviews.chandlerc.com/D1109
> 
> Thanks much.
>  -Mike