[lldb-dev] Patch for Review: Fix source list with symbol aliases

[jingham at apple.com]

That seems reasonable.  It should be simple, except there's a bunch of work we need to do to do fuzzy name matches (like folks expect if they look up foo::bar by name, it should match blah::foo::bar, etc.  So encapsulating that for symbols makes sense as it does with functions.  The FindFunctions with include_symbols=true is a separate thing, because it also does the work of coalescing symbols and functions so you don't end up with two copies of the same thing.

Jim

On Jul 10, 2013, at 11:47 AM, Michael Sartain <mikesart at gmail.com> wrote:

> On Wed, Jul 10, 2013 at 11:31 AM, <jingham at apple.com> wrote:
> It seems a little weird that if you've found no functions for a given name, you go looking for the symbols with that name by calling FindFunctions again, passing include_symbols=true.  You're making another pass over all the functions even though you know that's not going to turn up anything.  Why not just go look for symbols directly?
> 
> Good feedback. Would it make sense to add a FindFunctionSymbols() to ModuleList?
> 
> Thanks Jim.