[lldb-dev] Patch for Review: Fix source list with symbol aliases

[jingham at apple.com]

The basic idea is okay.  

It seems a little weird that if you've found no functions for a given name, you go looking for the symbols with that name by calling FindFunctions again, passing include_symbols=true.  You're making another pass over all the functions even though you know that's not going to turn up anything.  Why not just go look for symbols directly?

Jim


On Jul 10, 2013, at 11:19 AM, Michael Sartain <mikesart at gmail.com> wrote:

> I thought I had sent this to lldb-commits, but I'm not seeing it in the lldb-commits archives. So here is the request again...
> 
> "source list -n printf" wasn't working on Linux because printf is a symbol and the code was only searching for functions.
> 
> The patch now searches for symbols if function searching fails and tries to find a symbol that lines up exactly with a function.
> 
> The Linux test suite passes with this patch. Please let me know if it's ok to submit. Thanks.
>  -Mike
> 
> http://llvm-reviews.chandlerc.com/D1109
> 
> 
> _______________________________________________
> lldb-dev mailing list
> lldb-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev