[lldb-dev] [Patch] Check support for 'p' packet

[Abid, Hafiz]

Greg,
Thanks for review. Committed after making the suggested change.

Regards,
Abid

> -----Original Message-----
> From: Greg Clayton [mailto:gclayton at apple.com]
> Sent: 28 August 2013 20:55
> To: Abid, Hafiz
> Cc: lldb-dev at cs.uiuc.edu
> Subject: Re: [lldb-dev] [Patch] Check support for 'p' packet
> 
> Yes, OK to submit after you modify:
> 
> GDBRemoteCommunicationClient::ResetDiscoverableSettings()
> 
> to reset the new m_supports_p the calculate enum in the above function.
> 
> Greg
> 
> 
> On Aug 28, 2013, at 8:29 AM, Abid, Hafiz <Hafiz_Abid at mentor.com> wrote:
> 
> > Hi All,
> > Continuing with my efforts to make lddb work with gdbserver, I observed
> that lldb was always using 'p' packet for registers while gdbserver does not
> support it. So I have added code to check for support of this packet. If this is
> not available then we use 'g' packet. Tested with gdbserver and it worked ok.
> Also connected it with a modified qemu stub to make sure that 'p' packet
> availability check works fine. Ok to commit?
> >
> > Regards,
> > Abid
> > <p_packet.patch>_______________________________________________
> > lldb-dev mailing list
> > lldb-dev at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev