[lldb-dev] [patch] Checksum in non-ack mode

[Abid, Hafiz]

Greg,
Thanks for the review. I don't have commit access so please commit on my behalf.

Thanks,
Abid

> -----Original Message-----
> From: Greg Clayton [mailto:gclayton at apple.com]
> Sent: 20 August 2013 01:37
> To: Abid, Hafiz
> Cc: lldb-dev at cs.uiuc.edu
> Subject: Re: [lldb-dev] [patch] Checksum in non-ack mode
> 
> Looks fine. Do you have commit access?
> 
> Greg
> 
> On Aug 15, 2013, at 5:56 AM, Abid, Hafiz <Hafiz_Abid at mentor.com> wrote:
> 
> > Hi All,
> > I was trying to make LLDB with gdbserver. The thinking was to make LLDB
> work with a proper gdb stub that may be helpful to communicate with other
> targets and QEMU down the line. The first thing I noted was gdbserver
> issuing warning when LLDB connects to it. When in no-ack mode, LLDB does
> not calculate the checksum while gdbserver still expects the proper
> checksum even in no-ack mode. The online documentation [1] says.
> >
> > " When in no-acknowledgment mode, neither the stub nor gdb shall send
> or expect '+'/'-' protocol acknowledgments. The packet and response format
> still includes the normal checksum, as described in Overview, but the
> checksum may be ignored by the receiver".
> >
> > So it seems to me that debugger is supposed to send the checksum even in
> no-ack mode. I had a quick look at lldb-gdb-remote.txt and it does not
> mention that LLDB is overriding this behaviour. This patch fixes this issue.
> >
> > Regards,
> > Abid
> >
> > [1] http://sourceware.org/gdb/onlinedocs/gdb/Packet-
> Acknowledgment.html
> >
> > <checksum.patch>_______________________________________________
> > lldb-dev mailing list
> > lldb-dev at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev