[lldb-dev] [Patch to be reviewed] uuid_t under GNU/Linux

[Malea, Daniel]

Hi Sylvestre,

I can confirm the patch fixes the build, but I'm not sure we want to
introduce a new dependency on libuuid-dev (or equivalent), especially for
a library that's unlikely to be used on Linux. IIRC the only reason we
build it was because I was too lazy to add the darwin-specific logic when
writing the original cmake files.

I have a fix in place that conditionally builds the mac-specific
(problematic) libraries only on Darwin (and also speeds up the build
somewhat :) It's been committed in 179694.

Now, on to the hangs...

Thanks again for all your help with this issue,
Dan

On 2013-04-17 5:57 AM, "Sylvestre Ledru" <sylvestre at debian.org> wrote:

>Hello,
>
>I would like to know if I could apply the attached patch to lldb.
>
>Following the commit r179584 [1], we need, under GNU/Linux, to include
>uuid.h to obtain the uuid_t definition. Otherwise, the build fails with:
>/tmp/buildd/llvm-toolchain-3.3~svn179620/tools/lldb/source/Plugins/Dynamic
>Loader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp:714:42:
>error: 'uuid_t' was not declared in this scope
>For the full log, see [2].
>
>Since this adds a new dependency on lldb, I was to make sure people
>agree on this change (I can update the tools + documentation about this
>change).
>
>Thanks,
>Sylvestre
>
>[1]
>http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoade
>r/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp?r1=178191&r2=179584&pathrev=1795
>84
>[2]
>http://llvm-jenkins.debian.net/job/llvm-toolchain-codecoverage-binaries/ar
>chitecture=amd64,distribution=unstable/20/console
>