[lldb-dev] ; after if in AppleObjcRutnimev2.cpp

[Carlo Kok]

Op 31-10-2012 20:06, Greg Clayton schreef:
> No, not intended. Fixed with:
>
> % svn commit
> Sending        source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
> Transmitting file data .
> Committed revision 167160.
>
> Let us know if MSVC catches anything else!
>

It does:
StopInfo.cpp:570

result_code = ClangUserExpression::EvaluateWithError (exe_ctx,
   eExecutionPolicyOnlyWhenNeeded,
   lldb::eLanguageTypeUnknown,
   ClangUserExpression::eResultTypeAny,
   discard_on_error,
   wp_sp->GetConditionText(),
   NULL,
   result_value_sp,
   error,
   500000);
the .h has:
   lldb::ValueObjectSP &result_valobj_sp,
   Error &error,
   bool try_all_threads = true,
   uint32_t timeout_usec = 500000);

there's a bool between error & 500000 (though not really serious)

ASTResultSynthesizer.cpp:272
if (!implicit_cast->getCastKind() == CK_LValueToRValue)

that ! works on the GetCastKind() which probably wasn't what was meant


DataExtractor.cpp:724
if (sval64 & (1 << (bitfield_bit_size - 1)))

the (1 << (bitfield_bit_size - 1)) is an int32 and then widenned. 
Probably should be :
((uint64_t)1) << (bitfield_bit_size - 1)

That's it for lldb.