[lldb-dev] i386 support for linux

[Marco Minutoli]

On Wed, Feb 23, 2011 at 10:59 PM, Stephen Wilson <wilsons at start.ca> wrote:
> Hi Marco,
>
> On Wed, Feb 23, 2011 at 08:21:02PM +0100, Marco Minutoli wrote:
>> Hello everybody,
>>
>> some days ago I noticed that lldb at the moment is missing the support
>> for i386 debugging on Linux and having some spare time I tried to
>> modify the plugin for the x86_64 architecture. In the attachment you
>> can find the patch. Any comments/suggestions or whatever are welcome,
>> you know I am a student and I have a lot to learn.
>
> This looks really good!  Thanks so much for working on this!
>
>> Before updating from svn the patch was able to compile and lldb was
>> able to run programs on my 32bit installation of Ubuntu. Now It seems
>> that something is broken due to a missing method. The exact error is:
>>
>> LinuxThread.cpp:69:22: error: no member named 'GetGenericCPUType' in
>> 'lldb_private::ArchSpec'
>>         switch (arch.GetGenericCPUType())
>>
>> What has changed?
>
> We have a slightly different interface to the ArchSpec class committed in
> r126278.  I just sent out a patch series to address this here:
>
>  http://lists.cs.uiuc.edu/pipermail/lldb-commits/Week-of-Mon-20110221/002257.html
>
> This change means your patches will need to be updated slightly.
>
>
> I have a few more comments inline below:
>
>
>
>> Index: include/lldb/Expression/ClangExpressionVariable.h
>> ===================================================================
>> --- include/lldb/Expression/ClangExpressionVariable.h (revision 126320)
>> +++ include/lldb/Expression/ClangExpressionVariable.h (working copy)
>> @@ -117,7 +117,7 @@
>>      EnableParserVars()
>>      {
>>          if (!m_parser_vars.get())
>> -            m_parser_vars.reset(new struct ParserVars);
>> +            m_parser_vars.reset(new class ParserVars);
>>      }
>
>
> Can we just do "new ParserVars" here?
>

OPS :) this wasn't part of that patch. I was playing around doing some
clean up to become more confident with the code :).

>
>
> If you don't mind respinning the patch to address the above I would be
> more than happy to give it a good testing.
>

OK I will fix this things and I will send it back for testing.




-- 
Marco Minutoli
Skype: mminutoli
GPG-Key: 0x36AD4977

"If A is success in life, then A equals x plus y plus z. Work is x;
y is play; and z is keeping your mouth shut." --A. Einstein