[lldb-dev] [PATCH] Host.cpp and RegisterContextLinux_x86_64.cpp fixes

[Stephen Wilson]

Jai Menon <jmenon86 at gmail.com> writes:

> Hello,
>
> Patch 1 squashes these fixes into a single diff
> - r124942 removed a sys/wait.h inclusion. This is incorrect for Linux.

Looks good.

> - SetArch was removed which breaks the build on Linux.

Looks OK to unbreak the build.  Eventually we should probably return an
ArchSpec based on the host compile time triple (say from
llvm/Config/config.h).

> - Linux doesn't support RTLD_FIRST so apply that mode conditionally.

Why conditionally?  Perhaps we should just not pass this flag at all so
that we get similar behavior from this method on all posixy systems --
just a thought.

> Patch 2 fixes a missing include.

Looks good.

> On an unrelated note, is there a git mirror of lldb? Would patches
> created with git be okay?

I create all my patches using git and send them to lldb-commits for
review.  There is no official lldb git mirror.  I try to keep a git tree
up to date (time permitting) here: https://github.com/eightcien/lldb/

Linux work is on the lldb-linux branch.

--
steve