[lldb-dev] [PATCH] Fixing a warning

[William Lynch]

Here are some additional constructor fixes:

Index: source/Target/ThreadPlanStepOut.cpp
===================================================================
--- source/Target/ThreadPlanStepOut.cpp (revision 108458)
+++ source/Target/ThreadPlanStepOut.cpp (working copy)
@@ -39,9 +39,9 @@
     ThreadPlan (ThreadPlan::eKindStepOut, "Step out", thread, stop_vote,
run_vote),
     m_step_from_context (context),
     m_step_from_insn (LLDB_INVALID_ADDRESS),
+    m_return_bp_id(LLDB_INVALID_BREAK_ID),
     m_return_addr (LLDB_INVALID_ADDRESS),
     m_first_insn (first_insn),
-    m_return_bp_id(LLDB_INVALID_BREAK_ID),
     m_stop_others (stop_others)
 {
     m_step_from_insn = m_thread.GetRegisterContext()->GetPC(0);
Index: source/Target/Thread.cpp
===================================================================
--- source/Target/Thread.cpp (revision 108458)
+++ source/Target/Thread.cpp (working copy)
@@ -36,9 +36,9 @@

 Thread::Thread (Process &process, lldb::tid_t tid) :
     UserID (tid),
+    m_process (process),
     m_index_id (process.GetNextThreadIndexID ()),
     m_reg_context_sp (),
-    m_process (process),
     m_state (eStateUnloaded),
     m_plan_stack (),
     m_immediate_plan_stack(),
@@ -90,8 +90,8 @@

 Thread::StopInfo::StopInfo(Thread *thread) :
     m_reason (eStopReasonInvalid),
+    m_thread (thread),
     m_description (),
-    m_thread (thread),
     m_details ()
 {
     m_description[0] = '\0';
Index: source/Target/ThreadPlanStepInstruction.cpp
===================================================================
--- source/Target/ThreadPlanStepInstruction.cpp (revision 108458)
+++ source/Target/ThreadPlanStepInstruction.cpp (working copy)
@@ -39,9 +39,10 @@
 ) :
     ThreadPlan (ThreadPlan::eKindStepInstruction, "Step over single
instruction", thread, stop_vote, run_vote),
     m_instruction_addr (0),
+    m_stop_other_threads (stop_other_threads),
     m_step_over (step_over),
-    m_stack_depth(0),
-    m_stop_other_threads (stop_other_threads){
+    m_stack_depth(0)
+{
     m_instruction_addr = m_thread.GetRegisterContext()->GetPC(0);
     m_stack_depth = m_thread.GetStackFrameCount();
 }
Index: source/Target/ThreadPlan.cpp
===================================================================
--- source/Target/ThreadPlan.cpp (revision 108458)
+++ source/Target/ThreadPlan.cpp (working copy)
@@ -24,14 +24,14 @@
 // ThreadPlan constructor
 //----------------------------------------------------------------------
 ThreadPlan::ThreadPlan(ThreadPlanKind kind, const char *name, Thread
&thread, Vote stop_vote, Vote run_vote) :
+    m_thread (thread),
+    m_stop_vote (stop_vote),
+    m_run_vote (run_vote),
     m_kind (kind),
     m_name (name),
-    m_thread (thread),
+    m_plan_complete_mutex (Mutex::eMutexTypeRecursive),
     m_plan_complete(false),
-    m_plan_complete_mutex (Mutex::eMutexTypeRecursive),
     m_plan_private (false),
-    m_stop_vote (stop_vote),
-    m_run_vote (run_vote),
     m_okay_to_discard (false)
 {
     SetID (GetNextID());
Index: source/Target/ThreadPlanCallFunction.cpp
===================================================================
--- source/Target/ThreadPlanCallFunction.cpp (revision 108458)
+++ source/Target/ThreadPlanCallFunction.cpp (working copy)
@@ -37,11 +37,11 @@
                                                 bool discard_on_error) :
     ThreadPlan (ThreadPlan::eKindCallFunction, "Call function plan",
thread, eVoteNoOpinion, eVoteNoOpinion),
     m_valid(false),
-    m_process(thread.GetProcess()),
+    m_stop_other_threads(stop_other_threads),
     m_arg_addr (arg),
     m_args (NULL),
-    m_thread(thread),
-    m_stop_other_threads(stop_other_threads)
+    m_process(thread.GetProcess()),
+    m_thread(thread)
 {

     SetOkayToDiscard (discard_on_error);
@@ -91,11 +91,11 @@
                                                 bool discard_on_error) :
     ThreadPlan (ThreadPlan::eKindCallFunction, "Call function plan",
thread, eVoteNoOpinion, eVoteNoOpinion),
     m_valid(false),
-    m_process(thread.GetProcess()),
+    m_stop_other_threads(stop_other_threads),
     m_arg_addr (0),
     m_args (&args),
-    m_thread(thread),
-    m_stop_other_threads(stop_other_threads)
+    m_process(thread.GetProcess()),
+    m_thread(thread)
 {

     SetOkayToDiscard (discard_on_error);
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-dev/attachments/20100715/59ada64e/attachment.html>