[lldb-dev] ELF 64
eli.friedman at gmail.com
Wed Jul 7 15:36:44 PDT 2010
On Wed, Jul 7, 2010 at 11:24 AM, Stephen Wilson <wilsons at start.ca> wrote:
> Hi Eli,
> Eli Friedman <eli.friedman at gmail.com> writes:
>> Magic "1" is bad; use ELFCLASS32 (which is in the LLVM ELF.h).
> OK. Updated local elf.h with the constant. Updating llvm's ELF.h so we
> can use it is on my todo list.
>> Can you make the diff for ObjectFileELF64.cpp on top of an "svn cp"?
>> It's difficult to review otherwise.
> Attached is an updated patch set attempting to minimize changes between
> the 32 and 64 bit versions, and two diffs comparing the original and new
> Minor style differences between the two is an attempt to remain within
> 80 columns, and a preference for function application/declaration in the
> form "foo()" instead of with a space "foo ()" (I see both styles used in
> the code base. If there is a preference and I made the wrong choice I
> will be happy to fix it).
Your patch was committed.
There appear to be some interesting enhancements/bug-fixes in the
ELF-64 code compared to the ELF-32 code; would you mind writing a
cleanup patch for the ELF-32 code?
More information about the lldb-dev