[lldb-dev] [PATCH] Ctor init order fix.

[Greg Clayton]

On Jul 6, 2010, at 10:22 AM, Stephen Wilson wrote:

> 
> Greg Clayton <gclayton at apple.com> writes:
>> Ah! Keep sending us the patches then and we will apply them!
> 
> Many thanks!
> 
> While I have your ear:
> 
> I am testing a patch that adds support for 64 bit elf reading and am
> curious about coding conventions.  Are there plans for the LLDB code
> base to move towards the coding style used by LLVM/Clang?  There is a
> mail in the archives that suggests this may be the case.  In particular,
> should new files adopt the LLVM style or maintain consistency with the
> rest of LLDB?

We should maintain the consistency within LLDB. There are no plans to move the the LLVM/Clang coding conventions.

> Also, will any of the lldb devs consider joining in on #llvm?

I will get on there ASAP so I can be available.

Great news on the 64 bit ELF support!

Greg Clayton

> 
> Thanks!
> Steve
> 
> 
>> 
>> Greg Clayton
>> 
>> On Jul 6, 2010, at 9:42 AM, Stephen Wilson wrote:
>> 
>>> Hi Greg,
>>> 
>>> Greg Clayton <gclayton at apple.com> writes:
>>> 
>>>> For simple patches like this one, feel free to go ahead and just commit them!
>>> 
>>> I would if I had commit access!   This is the first patch I have sent to
>>> an LLVM related project.
>>> 
>>> 
>>> Take care,
>>> Steve
>>> 
>>>> 
>>>> Greg Clayton
>>>> 
>>>> On Jul 2, 2010, at 8:38 PM, Stephen Wilson wrote:
>>>> 
>>>>> 
>>>>> Hi all,
>>>>> 
>>>>> My hope is to help with the linux port.  Initially I would like to clean
>>>>> up many of the compiler warnings I am seeing as a way to familiarize
>>>>> myself with the basic code layout.   Attached patch fixes a ctor
>>>>> initialization order warning.
>>>>> 
>>>>> I am seeing many warnings, largely trivial.  Am I correct in assuming
>>>>> small patches like this one (file-by-file basis) are preferred?
>>>>> 
>>>>> 
>>>>> Thanks,
>>>>> Steve
>>>>> 
>>>>> diff --git a/source/Symbol/LineEntry.cpp b/source/Symbol/LineEntry.cpp
>>>>> index fb362b9..83c50f2 100644
>>>>> --- a/source/Symbol/LineEntry.cpp
>>>>> +++ b/source/Symbol/LineEntry.cpp
>>>>> @@ -20,9 +20,9 @@ LineEntry::LineEntry() :
>>>>>   column(0),
>>>>>   is_start_of_statement(0),
>>>>>   is_start_of_basic_block(0),
>>>>> -    is_terminal_entry(0),
>>>>>   is_prologue_end(0),
>>>>> -    is_epilogue_begin(0)
>>>>> +    is_epilogue_begin(0),
>>>>> +    is_terminal_entry(0)
>>>>> {
>>>>> }
>>>>> 
>>>>> _______________________________________________
>>>>> lldb-dev mailing list
>>>>> lldb-dev at cs.uiuc.edu
>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
>> 
>> 
>> _______________________________________________
>> lldb-dev mailing list
>> lldb-dev at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev