[lldb-dev] [PATCH] Ctor init order fix.

[Greg Clayton]

Ah! Keep sending us the patches then and we will apply them!

Greg Clayton

On Jul 6, 2010, at 9:42 AM, Stephen Wilson wrote:

> Hi Greg,
> 
> Greg Clayton <gclayton at apple.com> writes:
> 
>> For simple patches like this one, feel free to go ahead and just commit them!
> 
> I would if I had commit access!   This is the first patch I have sent to
> an LLVM related project.
> 
> 
> Take care,
> Steve
> 
>> 
>> Greg Clayton
>> 
>> On Jul 2, 2010, at 8:38 PM, Stephen Wilson wrote:
>> 
>>> 
>>> Hi all,
>>> 
>>> My hope is to help with the linux port.  Initially I would like to clean
>>> up many of the compiler warnings I am seeing as a way to familiarize
>>> myself with the basic code layout.   Attached patch fixes a ctor
>>> initialization order warning.
>>> 
>>> I am seeing many warnings, largely trivial.  Am I correct in assuming
>>> small patches like this one (file-by-file basis) are preferred?
>>> 
>>> 
>>> Thanks,
>>> Steve
>>> 
>>> diff --git a/source/Symbol/LineEntry.cpp b/source/Symbol/LineEntry.cpp
>>> index fb362b9..83c50f2 100644
>>> --- a/source/Symbol/LineEntry.cpp
>>> +++ b/source/Symbol/LineEntry.cpp
>>> @@ -20,9 +20,9 @@ LineEntry::LineEntry() :
>>>    column(0),
>>>    is_start_of_statement(0),
>>>    is_start_of_basic_block(0),
>>> -    is_terminal_entry(0),
>>>    is_prologue_end(0),
>>> -    is_epilogue_begin(0)
>>> +    is_epilogue_begin(0),
>>> +    is_terminal_entry(0)
>>> {
>>> }
>>> 
>>> _______________________________________________
>>> lldb-dev mailing list
>>> lldb-dev at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev