[Lldb-commits] [lldb] [lldb] Don't cache symtabs for memory modules w/ corefile (PR #237050)

[Jason Molenda via lldb-commits]

jasonmolenda wrote:

I think the one outstanding point being discussed is about Module::GetIndexCache, which I saw as the central authority for deciding if we should create a DataFileCache for a given binary we are examining.  e.g. I am currently passing in "is this a memory module" and "should memory module caching be allowed" -- which clearly the caller could compare those two and avoid making a call to Module::GetIndexCache altogether.  But I thought it was cleaner to have all of the logic about whether to cache or not centralized in that static method.

I also mention, https://github.com/llvm/llvm-project/pull/237050#discussion_r4450834703 , how maybe I should have different GetIndexCache methods for the different classes of files I'm creating/memory modules.  

I think everything else is addressed here.  Thanks for the close reading, Jim.

https://github.com/llvm/llvm-project/pull/237050