[Lldb-commits] [lldb] [lldb][NativePDB] Accept functions without a type (PR #236547)

[Charles Zablit via lldb-commits]

================
@@ -598,32 +598,34 @@ lldb::FunctionSP SymbolFileNativePDB::CreateFunction(PdbCompilandSymId func_id,
                    "Failed to deserialize ProcSym record: {0}");
     return nullptr;
   }
-  if (proc.FunctionType == TypeIndex::None())
-    return nullptr;
-  TypeSP func_type = GetOrCreateType(proc.FunctionType);
-  if (!func_type)
----------------
charles-zablit wrote:

I meant when `GetOrCreateType` fails on a type that is not a `None` index. In that situation, we return a UID with no type associated with it, so every `GetType()` call fails and retries.

Could we only set `func_type_uid` if `func_type` is not null, and return early if `!func_type == true`?

https://github.com/llvm/llvm-project/pull/236547