[Lldb-commits] [lldb] [lldb-dap] Support interactive multiline REPL commands via input pipe (PR #237428)

[John Harrison via lldb-commits]

ashgti wrote:

Forgot to mention in the commit message but this should fix #131944.

> Would it be worth splitting the core change (eBroadcastBitReadyForInput) from the lldb-dap side? The signal looks useful on its own. Also this could use review from @jimingham?

Sure, I can split this up, I can start working on that.

> One question, if lldb launched the process, is it intentional that typed lines go to the inferior's stdin while it's running, and not to the command interpreter? That's my read of the patch. It could be a good thing, since DAP doesn't give access to the debuggee stdin. But it'd also be a shame not to be able to run commands until the next stop. I would prefer a dedicated category for this probably. (or some other explicit method)
>
> As this is this seems to also not address the prompt issues. This is something that I was looking to address as its own extension of DAP but as a bundle for interactive command support (something the client and server would have to advertise as a capability)

We're not sending data to the processes' stdin, we're sending it to the debugger's stdin.

If you want the process to have a stdin then you can use `"console": "integratedTerminal"` or `"console": "externalTerminal"` and the process would have stdin hooked up to a pty. 

https://github.com/llvm/llvm-project/pull/237428