[Lldb-commits] [lldb] [lldb] Format `atomic<shared_ptr>` on MSVC STL (PR #237631)

[Charles Zablit via lldb-commits]

================
@@ -29,20 +31,39 @@ class MsvcStlAtomicSyntheticFrontEnd : public SyntheticChildrenFrontEnd {
   llvm::Expected<size_t> GetIndexOfChildWithName(llvm::StringRef name) override;
 
 private:
-  ValueObject *m_storage = nullptr;
-  CompilerType m_element_type;
+  ValueObjectSP m_storage;
----------------
charles-zablit wrote:

This looks like a potential leak and should stay a raw pointer: https://github.com/llvm/llvm-project/blob/e20f670671d37374be1cb94287daea370adad3a7/lldb/source/Plugins/Language/CPlusPlus/GenericErrorCode.cpp#L64-L66

https://github.com/llvm/llvm-project/pull/237631