[Lldb-commits] [lldb] [lldb] Don't let a reader starve ConnectionFileDescriptor::Disconnect (PR #236558)

[Charles Zablit via lldb-commits]

charles-zablit wrote:

> > On Windows the command pipe cannot wake a reader blocked in `select()`,
> 
> If that is the case, how does the command pipe work on Windows? This is the typical producer-consumer pattern, where consumer is blocked by `select()` if producer doesn't write anything.

It does not: https://github.com/llvm/llvm-project/blob/3108004264effc7c4e5925528386ef8f6e99eb6f/lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp#L446-L456

The next step after merging this PR is to do what the FIXME and the comment block say, but that's a bigger refactor.



https://github.com/llvm/llvm-project/pull/236558