[Lldb-commits] [lldb] [lldb][NativePDB] Accept functions without a type (PR #236547)

[via lldb-commits]

================
@@ -598,32 +598,34 @@ lldb::FunctionSP SymbolFileNativePDB::CreateFunction(PdbCompilandSymId func_id,
                    "Failed to deserialize ProcSym record: {0}");
     return nullptr;
   }
-  if (proc.FunctionType == TypeIndex::None())
-    return nullptr;
-  TypeSP func_type = GetOrCreateType(proc.FunctionType);
-  if (!func_type)
----------------
Nerixyz wrote:

I don't understand which of the new code you're referring here. `GetOrCreateType` can fail. At this point, we don't know if `FunctionType` is a valid type index (although we do know that it's not 0). If it fails in the new code, the function's type will be empty, but it will have a uid.

https://github.com/llvm/llvm-project/pull/236547