[Lldb-commits] [lldb] [llvm] [lldb] Support DW_AT_address_class on pointer types in DWARFASTParserClang (PR #230555)

[Michael Buch via lldb-commits]

================
@@ -4686,6 +4696,19 @@ TypeSystemClang::AddPtrAuthModifier(lldb::opaque_compiler_type_t type,
   return CompilerType();
 }
 
+CompilerType
+TypeSystemClang::AddAddressSpaceModifier(lldb::opaque_compiler_type_t type,
+                                         uint32_t address_space) {
+  if (type && address_space <= clang::Qualifiers::MaxAddressSpace) {
----------------
Michael137 wrote:

I would turn these into an assert. We already refuse to set out-of-range address classes when parsing DWARF. The callers of this API are responsible for ensuring that invariant gets carried forward
```suggestion
  assert (type);
  assert (address_space <= clang::Qualifiers::MaxAddressSpace);
```

https://github.com/llvm/llvm-project/pull/230555