[Lldb-commits] [lldb] [lldb] Select signal-frame CFI at the raw PC (PR #223109)

[Jason Molenda via lldb-commits]

================
@@ -142,6 +142,22 @@ bool RegisterContextUnwind::IsUnwindPlanValidForCurrentPC(
   return false;
 }
 
+bool RegisterContextUnwind::IsSignalFrameAtRawPC() {
----------------
jasonmolenda wrote:

I wonder if this should be included in `RegisterContextUnwind::IsTrapHandlerSymbol` which currently only looks at the function name based on the `m_sym_ctx`.

That method is weird, it takes arguments of `Process*` and `SymbolContext` but it's a regular RegisterContextUnwind method.  The callers all pass `m_sym_ctx` as the second argument, which this method could already access.  And in other places in this method we do
```
  ExecutionContext exe_ctx(m_thread.shared_from_this());
  Process *process = exe_ctx.GetProcessPtr();
```

I guess passing in the `Process*` could avoid duplicating that.  It's kind of weirdly written though.
(Note, I'm sure I wrote this 10+ years ago, i'm sure it's my fault)

https://github.com/llvm/llvm-project/pull/223109