[Lldb-commits] [lldb] [lldb] Don't cache symtabs for memory modules w/ corefile (PR #237050)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- lldb/test/API/functionalities/module_cache/corefile_memory_module/main.cpp lldb/include/lldb/Core/Module.h lldb/include/lldb/Expression/ObjectFileJIT.h lldb/include/lldb/Symbol/ObjectFile.h lldb/include/lldb/Symbol/Symtab.h lldb/include/lldb/lldb-private-interfaces.h lldb/source/Core/Module.cpp lldb/source/Expression/ObjectFileJIT.cpp lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp lldb/source/Plugins/DynamicLoader/FreeBSD-Kernel/DynamicLoaderFreeBSDKernel.cpp lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.h lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.h lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.h lldb/source/Plugins/ObjectFile/JSON/ObjectFileJSON.cpp lldb/source/Plugins/ObjectFile/JSON/ObjectFileJSON.h lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.h lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.h lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h lldb/source/Plugins/ObjectFile/Placeholder/ObjectFilePlaceholder.cpp lldb/source/Plugins/ObjectFile/XCOFF/ObjectFileXCOFF.cpp lldb/source/Plugins/ObjectFile/XCOFF/ObjectFileXCOFF.h lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.h lldb/source/Symbol/ObjectFile.cpp lldb/source/Symbol/Symtab.cpp lldb/source/Target/Process.cpp lldb/unittests/ObjectFile/MachO/TestObjectFileMachO.cpp lldb/unittests/Symbol/SymtabTest.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp b/lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
index 054af037a..7428523ae 100644
--- a/lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
+++ b/lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
@@ -674,8 +674,7 @@ bool DynamicLoaderDarwinKernel::KextImageInfo::ReadMemoryModule(
   }
 
   llvm::Expected<ModuleSP> memory_module_sp_or_err =
-      process->ReadModuleFromMemory(file_spec, m_load_address,
-                                    size_to_read);
+      process->ReadModuleFromMemory(file_spec, m_load_address, size_to_read);
   if (auto err = memory_module_sp_or_err.takeError()) {
     LLDB_LOG_ERROR(log, std::move(err),
                    "KextImageInfo::ReadMemoryModule failed to read module from "
diff --git a/lldb/source/Plugins/DynamicLoader/FreeBSD-Kernel/DynamicLoaderFreeBSDKernel.cpp b/lldb/source/Plugins/DynamicLoader/FreeBSD-Kernel/DynamicLoaderFreeBSDKernel.cpp
index 6a74c9a67..eb08683f4 100644
--- a/lldb/source/Plugins/DynamicLoader/FreeBSD-Kernel/DynamicLoaderFreeBSDKernel.cpp
+++ b/lldb/source/Plugins/DynamicLoader/FreeBSD-Kernel/DynamicLoaderFreeBSDKernel.cpp
@@ -395,8 +395,7 @@ bool DynamicLoaderFreeBSDKernel::KModImageInfo::ReadMemoryModule(
   }
 
   llvm::Expected<ModuleSP> memory_module_sp_or_err =
-      process->ReadModuleFromMemory(file_spec, m_load_address,
-                                    size_to_read);
+      process->ReadModuleFromMemory(file_spec, m_load_address, size_to_read);
   if (auto err = memory_module_sp_or_err.takeError()) {
     LLDB_LOG_ERROR(log, std::move(err),
                    "KextImageInfo::ReadMemoryModule: Failed to read module "

``````````

</details>


https://github.com/llvm/llvm-project/pull/237050