[Lldb-commits] [lldb] [lldb][NativePDB] Find namespaces that only contain typedefs (PR #233460)

[via lldb-commits]

================
@@ -3055,6 +3069,17 @@ void SymbolFileNativePDB::BuildParentMap() {
     llvm::StringRef base_name =
         MSVCUndecoratedNameParser::DropScope(udt_or_err->Name);
     m_typedef_base_names.Append(ConstString(base_name), gid);
+
+    if (std::optional<Type::ParsedName> parsed_name =
+            Type::GetTypeScopeAndBasename(udt_or_err->Name)) {
----------------
Nerixyz wrote:

Why is this using `Type::GetTypeScopeAndBasename`? Does that handle msvc names? There's ` MSVCUndecoratedNameParser::ExtractContextAndIdentifier` - we already use `GetBaseName` above and this is basically an extension of it.

https://github.com/llvm/llvm-project/pull/233460