[Lldb-commits] [lldb] [lldb][Darwin] Batch debugserver Mach-O load-command reads (PR #232684)

[Karim Alweheshy via lldb-commits]

karim-alweheshy wrote:

@jasonmolenda I don’t yet have a controlled end-to-end attach number for this PR alone. I’ll follow up with a reproducible before/after benchmark of both the all-images query and complete attach, keeping the app and LLDB client fixed and changing only debugserver. That should establish the aggregate benefit, including a control with few loaded images.

Agreed on simplifying the buffer. The local `std::array` puts 16 KB on the stack. The window was intended to avoid allocating directly from the inferior’s `sizeofcmds`, but a guarded `std::vector<uint8_t>` bulk read with exact-prefix reads as the fallback would remove the refill bookkeeping. The fallback matters when an unknown command’s payload is unreadable but later command headers are still accessible; the existing tests cover that and a huge declared size. I’ll use that simpler approach while retaining the command-size/overflow checks and breakpoint-aware `ReadMemory`.


https://github.com/llvm/llvm-project/pull/232684