[Lldb-commits] [lldb] 922869f - [lldb][test] Accept legacy register index overflow diagnostic (#233764)

[via lldb-commits]

Author: Bar Soloveychik
Date: 2026-10-20T11:18:31+01:00
New Revision: 922869f0e554f928a27b651ec3eff9d3cc2be2ba

URL: https://github.com/llvm/llvm-project/commit/922869f0e554f928a27b651ec3eff9d3cc2be2ba
DIFF: https://github.com/llvm/llvm-project/commit/922869f0e554f928a27b651ec3eff9d3cc2be2ba.diff

LOG: [lldb][test] Accept legacy register index overflow diagnostic (#233764)

[ARM builder was failing
](https://lab.llvm.org/buildbot/#/builders/18/builds/27896)after I
merged https://github.com/llvm/llvm-project/pull/224147

because `TestXMLRegisterUnion.py` expected the legacy expression parser
to report oversized vector indexes with array index, but on 32-bit ARM
the index `4294967296` overflows long during parsing first, so LLDB
reports invalid index expression `""` instead. The command still fails
correctly; only the test’s expected diagnostic was too specific.

Co-authored-by: Bar Soloveychik <barsolo at fb.com>

Added: 
    

Modified: 
    lldb/test/API/functionalities/gdb_remote_client/TestXMLRegisterUnion.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/gdb_remote_client/TestXMLRegisterUnion.py b/lldb/test/API/functionalities/gdb_remote_client/TestXMLRegisterUnion.py
index 36571f054b60dc..0e74a1cfb25e31 100644
--- a/lldb/test/API/functionalities/gdb_remote_client/TestXMLRegisterUnion.py
+++ b/lldb/test/API/functionalities/gdb_remote_client/TestXMLRegisterUnion.py
@@ -747,11 +747,21 @@ def test_invalid_union_member_paths(self):
         try:
             for command in [
                 "register read v0[9].f32",
-                "register read v0[4294967296]",
                 "v $v0[9].f32",
-                "v $v0[4294967296]",
             ]:
                 self.expect(command, error=True, substrs=["array index"])
+            for command in [
+                "register read v0[4294967296]",
+                "v $v0[4294967296]",
+            ]:
+                self.expect(
+                    command,
+                    error=True,
+                    patterns=[
+                        r"(array index 4294967296 is not valid|"
+                        r"invalid index expression \"\")"
+                    ],
+                )
             for command in [
                 "register read u0.raw[64]",
                 "register read u0.raw[64-64]",