[Lldb-commits] [lldb] [llvm] [lldb] Extract reusable native register contexts (PR #233620)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- lldb/source/Plugins/Process/AIX/NativeRegisterContextAIX.h lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD.h lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.h lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_x86.h lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.h lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.h lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64dbreg.h lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_loongarch64.h lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86.h lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD.h lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86.h lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows.h lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm64.h lldb/source/Plugins/Register/Native/NativeRegisterContextDBReg.cpp lldb/source/Plugins/Register/Native/NativeRegisterContextDBReg.h lldb/source/Plugins/Register/Native/NativeRegisterContextDBReg_arm.cpp lldb/source/Plugins/Register/Native/NativeRegisterContextDBReg_arm.h lldb/source/Plugins/Register/Native/NativeRegisterContextDBReg_arm64.cpp lldb/source/Plugins/Register/Native/NativeRegisterContextDBReg_arm64.h lldb/source/Plugins/Register/Native/NativeRegisterContextDBReg_loongarch.cpp lldb/source/Plugins/Register/Native/NativeRegisterContextDBReg_loongarch.h lldb/source/Plugins/Register/Native/NativeRegisterContextDBReg_x86.cpp lldb/source/Plugins/Register/Native/NativeRegisterContextDBReg_x86.h lldb/source/Plugins/Register/Native/NativeRegisterContextRegisterInfo.cpp lldb/source/Plugins/Register/Native/NativeRegisterContextRegisterInfo.h --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.h b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.h
index cdb8c8f3e..057b57ce9 100644
--- a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.h
+++ b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.h
@@ -13,8 +13,8 @@
 
 #include "Plugins/Process/Linux/NativeRegisterContextLinux.h"
 #include "Plugins/Register/Native/NativeRegisterContextDBReg_arm.h"
-#include "Register/Common/RegisterInfo_arm.h"
 #include "Register/Arch/lldb-arm-register-enums.h"
+#include "Register/Common/RegisterInfo_arm.h"
 
 namespace lldb_private {
 namespace process_linux {
diff --git a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86.h b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86.h
index 4cf6005a4..d71301185 100644
--- a/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86.h
+++ b/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86.h
@@ -13,9 +13,9 @@
 
 #include "Plugins/Process/Linux/NativeRegisterContextLinux.h"
 #include "Plugins/Register/Native/NativeRegisterContextDBReg_x86.h"
-#include "Register/Linux/RegisterInfoLinux_x86.h"
 #include "Register/Arch/RegisterContext_x86.h"
 #include "Register/Arch/lldb-x86-register-enums.h"
+#include "Register/Linux/RegisterInfoLinux_x86.h"
 #include <optional>
 #include <sys/uio.h>
 
diff --git a/lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86.h b/lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86.h
index 7d0f5ee7a..af02c3f78 100644
--- a/lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86.h
+++ b/lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86.h
@@ -22,8 +22,8 @@
 #include <optional>
 
 #include "Plugins/Process/NetBSD/NativeRegisterContextNetBSD.h"
-#include "Register/Arch/RegisterContext_x86.h"
 #include "Plugins/Register/Native/NativeRegisterContextDBReg_x86.h"
+#include "Register/Arch/RegisterContext_x86.h"
 #include "Register/Arch/lldb-x86-register-enums.h"
 
 namespace lldb_private {
diff --git a/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm64.h b/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm64.h
index fd00009fd..e59ccd1af 100644
--- a/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm64.h
+++ b/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm64.h
@@ -13,8 +13,8 @@
 #include "NativeRegisterContextWindows.h"
 
 #include "Plugins/Register/Native/NativeRegisterContextDBReg_arm64.h"
-#include "Register/Common/RegisterInfo_arm64.h"
 #include "Register/Arch/lldb-arm64-register-enums.h"
+#include "Register/Common/RegisterInfo_arm64.h"
 
 #include "lldb/Host/windows/windows.h"
 
diff --git a/lldb/source/Plugins/Register/Native/NativeRegisterContextRegisterInfo.h b/lldb/source/Plugins/Register/Native/NativeRegisterContextRegisterInfo.h
index 48465cd0e..9c5cf88c8 100644
--- a/lldb/source/Plugins/Register/Native/NativeRegisterContextRegisterInfo.h
+++ b/lldb/source/Plugins/Register/Native/NativeRegisterContextRegisterInfo.h
@@ -39,5 +39,5 @@ public:
 protected:
   std::unique_ptr<RegisterInfoInterface> m_register_info_interface_up;
 };
-}
+} // namespace lldb_private
 #endif

``````````

</details>


https://github.com/llvm/llvm-project/pull/233620