[Lldb-commits] [lldb] [lldb][Darwin] Batch debugserver Mach-O load-command reads (PR #232684)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {darker}-->


:warning: Python code formatter, darker found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
darker --check --diff -r origin/main...HEAD lldb/test/API/macosx/unregistered-macho/TestUnregisteredMacho.py
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from darker here.
</summary>

``````````diff
--- TestUnregisteredMacho.py	2026-10-16 10:57:28.000000 +0000
+++ TestUnregisteredMacho.py	2026-10-16 11:04:34.031885 +0000
@@ -85,29 +85,41 @@
         self.assertEqual(image["uuid"], "12345678-1234-5678-ABCD-0123456789AB")
         self.assertEqual(image["mach_header"]["magic"], 0xFEEDFACF)
         self.assertEqual(image["mach_header"]["cpusubtype"], 5)
         self.assertEqual(image["min_version_os_name"], "macosx")
         self.assertEqual(image["min_version_os_sdk"], version)
-        self.assertEqual(image["segments"], [
-            {
-                "name": "1234567890abcdef", "vmaddr": 0x123456789ABCDEF0,
-                "vmsize": 0x10000, "fileoff": 0x1000, "filesize": 0x2000,
-                "maxprot": 7,
-            },
-            {
-                "name": "__TEXT32", "vmaddr": 0x5000, "vmsize": 0x1000,
-                "fileoff": 0x20, "filesize": 0x200, "maxprot": 5,
-            },
-        ])
+        self.assertEqual(
+            image["segments"],
+            [
+                {
+                    "name": "1234567890abcdef",
+                    "vmaddr": 0x123456789ABCDEF0,
+                    "vmsize": 0x10000,
+                    "fileoff": 0x1000,
+                    "filesize": 0x2000,
+                    "maxprot": 7,
+                },
+                {
+                    "name": "__TEXT32",
+                    "vmaddr": 0x5000,
+                    "vmsize": 0x1000,
+                    "fileoff": 0x20,
+                    "filesize": 0x200,
+                    "maxprot": 5,
+                },
+            ],
+        )
 
     @no_debug_info_test
     @skipUnlessDarwin
     def test_load_command_prefixes_across_cache_boundaries(self):
         target, process = self.start_load_command_fixture()
-        for name, version in [("crossing_image", "13.2.1"),
-                              ("large_image", "10.12"),
-                              ("unreadable_unknown_image", "13.2.1")]:
+        for name, version in [
+            ("crossing_image", "13.2.1"),
+            ("large_image", "10.12"),
+            ("unreadable_unknown_image", "13.2.1"),
+        ]:
             address = self.image_address(target, name)
             images = self.image_info(address)
             self.assertEqual(len(images), 1, name)
             self.assertEqual(images[0]["load_address"], address)
             self.check_prefixes(images[0], version)
@@ -129,12 +141,15 @@
 
     @no_debug_info_test
     @skipUnlessDarwin
     def test_unreadable_optional_load_command_payloads(self):
         target, process = self.start_load_command_fixture()
-        for name in ["unreadable_uuid_image", "unreadable_version_image",
-                     "huge_size_image"]:
+        for name in [
+            "unreadable_uuid_image",
+            "unreadable_version_image",
+            "huge_size_image",
+        ]:
             images = self.image_info(self.image_address(target, name))
             self.assertEqual(len(images), 1, name)
             self.assertEqual(images[0]["segments"], [])
             self.assertNotIn("min_version_os_name", images[0])
         images = self.image_info(self.image_address(target, "unreadable_segment_image"))
@@ -142,9 +157,15 @@
 
     @no_debug_info_test
     @skipUnlessDarwin
     def test_malformed_load_command_prefixes(self):
         target, process = self.start_load_command_fixture()
-        for name in ["invalid_size_image", "invalid_count_image",
-                     "invalid_prefix_image", "invalid_overrun_image"]:
-            self.assertEqual(self.image_info(self.image_address(target, name)), [], name)
+        for name in [
+            "invalid_size_image",
+            "invalid_count_image",
+            "invalid_prefix_image",
+            "invalid_overrun_image",
+        ]:
+            self.assertEqual(
+                self.image_info(self.image_address(target, name)), [], name
+            )
         self.assertEqual(self.image_info((1 << 64) - 8), [])

``````````

</details>


https://github.com/llvm/llvm-project/pull/232684