[Lldb-commits] [lldb] d9a5008 - Revert "[LLDB] Remove fallthrough (#216398)" (#232476)

[via lldb-commits]

Author: Alex Langford
Date: 2026-10-15T13:50:16-07:00
New Revision: d9a50081748a471bdfc5ba787faf3b7fbacf0c05

URL: https://github.com/llvm/llvm-project/commit/d9a50081748a471bdfc5ba787faf3b7fbacf0c05
DIFF: https://github.com/llvm/llvm-project/commit/d9a50081748a471bdfc5ba787faf3b7fbacf0c05.diff

LOG: Revert "[LLDB] Remove fallthrough (#216398)" (#232476)

This reverts commit 99690a356c8c059db73786adecd827d7f20e3297.

This commit broke lldb-defines.h. The version defines are never filled
in because the unifdef copy_command overrides calling the
version-header-fix script. This does mean that you can't remove any SWIG
preprocessor macros from lldb-defines right now, but there are none
currently.

Added: 
    

Modified: 
    lldb/source/API/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/lldb/source/API/CMakeLists.txt b/lldb/source/API/CMakeLists.txt
index ddbb8958cd609..eb81fa93c49f4 100644
--- a/lldb/source/API/CMakeLists.txt
+++ b/lldb/source/API/CMakeLists.txt
@@ -322,8 +322,7 @@ foreach(header
         ${LLDB_SOURCE_DIR}/scripts/version-header-fix.py
         -i ${header} -o ${staged_header}
         -m ${LLDB_VERSION_MAJOR} -n ${LLDB_VERSION_MINOR} -p ${LLDB_VERSION_PATCH})
-  endif()
-  if(unifdef_EXECUTABLE)
+  elseif(unifdef_EXECUTABLE)
     # unifdef returns 0 when the file is unchanged and 1 if something was changed.
     # That means if we successfully remove SWIG code, the build system believes
     # that the command has failed and stops. This is undesirable.