[Lldb-commits] [lldb] [llvm] [lldb] Move OS-specific UnixSignals subclasses from Plugins to Target (PR #229106)

[Pavel Labath via lldb-commits]

labath wrote:

Hmm... I forgot about that part. Sorry about that.

I would say that this part should be removed from lldb-server as well, and pretty much for the same reason: this logic needs to exist in the lldb client anyway (core dumps, etc.), so there's no point in duplicating it in lldb-server. This would also let us be more flexible in how we define the format strings. Currently, the format strings are fairly rigid because they have to fit into the generic SignalCode map, if Platforms(*) were in charge of the formatting they could go wild (add the PID which sent the signal or whatever else info they can gather).

I'm not entirely sure how easy would it be to unhook this dependency, but I'll give that a shot (probably next week).

(*) To be fair, the same effect could be achieved by making the signals class a regular plugin(lite).

https://github.com/llvm/llvm-project/pull/229106