[Lldb-commits] [lldb] [lldb][minidump][test] Re-enable the TLS test (PR #231425)

[David Spickett via lldb-commits]

https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/231425

>From c0927ed6fe2a521176967e0ca8eb7a19604485d3 Mon Sep 17 00:00:00 2001
From: David Spickett <david.spickett at arm.com>
Date: Tue, 13 Oct 2026 09:32:30 +0000
Subject: [PATCH 1/2] [lldb][minidump][test] Re-enable the TLS test

This has not been running / never was, because it did not have
the test_ prefix. I got it running on AArch64 enough to update
the code.

It fails on AArch64 which is not unexpected, TLS support is
relatively recent there.

So I'm just re-enabling this to see if it works on x86_64
still.
---
 .../TestProcessSaveCoreMinidump.py                          | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py b/lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py
index d82f05a0b47b8..f2ea865d8f97f 100644
--- a/lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py
+++ b/lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py
@@ -635,7 +635,7 @@ def minidump_deterministic_difference(self):
 
     @skipUnlessPlatform(["linux"])
     @skipUnlessArch("x86_64")
-    def minidump_saves_tls(self):
+    def test_minidump_saves_tls(self):
         self.build()
         exe = self.getBuildArtifact("a.out")
         try:
@@ -656,10 +656,10 @@ def minidump_saves_tls(self):
             core_target = self.dbg.CreateTarget(None)
             core_proc = core_target.LoadCore(tls_file)
             frame = core_proc.GetThreadAtIndex(0).GetFrameAtIndex(0)
-            tls_val = frame.FindValue("lf")
+            tls_val = frame.FindValue("lf", lldb.eValueTypeVariableGlobal)
             self.assertEqual(tls_val.GetValueAsUnsigned(), 42)
 
-        except:
+        finally:
             self.assertTrue(self.dbg.DeleteTarget(target))
             if os.path.isfile(tls_file):
                 os.unlink(tls_file)

>From 45202e2134eae6ef4d99d1b93e2213cc6e1945c9 Mon Sep 17 00:00:00 2001
From: David Spickett <david.spickett at arm.com>
Date: Tue, 13 Oct 2026 09:56:52 +0000
Subject: [PATCH 2/2] xfail it

---
 .../process_save_core_minidump/TestProcessSaveCoreMinidump.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py b/lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py
index f2ea865d8f97f..49d262a73c1f4 100644
--- a/lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py
+++ b/lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py
@@ -634,7 +634,9 @@ def minidump_deterministic_difference(self):
             self.assertTrue(self.dbg.DeleteTarget(target))
 
     @skipUnlessPlatform(["linux"])
-    @skipUnlessArch("x86_64")
+    @skipIf(archs=no_match(["x86_64", "aarch64"]))
+    # We find the variable but its value is 0.
+    @expectedFailureAll(archs=["x86_64", "aarch64"])
     def test_minidump_saves_tls(self):
         self.build()
         exe = self.getBuildArtifact("a.out")