[Lldb-commits] [lldb] [lldb] Add `scripting extension list --instances` (PR #226043)

[Jonas Devlieghere via lldb-commits]

================
@@ -101,8 +109,37 @@ class ScriptedInterface {
   }
 
 protected:
+  void RegisterInstance(const lldb::ScriptedInstanceRegistrySP &registry_sp,
+                        llvm::StringRef class_name, FileSpec source_path,
+                        StructuredData::DictionarySP args_sp) {
+    UnregisterInstance();
+    if (!registry_sp)
+      return;
+    ScriptedInstanceInfo info;
+    info.plugin_name = GetPluginName();
+    info.class_name = class_name.str();
----------------
JDevlieghere wrote:

If we're going to covert this StringRef to a `std::string`, we may as well make it by value and move it here, avoiding a copy when this function is called with an rvalue reference.

https://github.com/llvm/llvm-project/pull/226043