[Lldb-commits] [lldb] [lldb][NativePDB] Require native for thread locals (PR #229480)

[via lldb-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Nerixyz (Nerixyz)

<details>
<summary>Changes</summary>

Skips the test for builds that are not native and intends to fix the still broken bot after #<!-- -->229340.

The test shouldn't require `native`, but, as I mentioned in the comment, it seems like the linking in `build.py` doesn't set the correct architecture or the build doesn't happen on the correct target. Either way, I can't debug this locally, so this configuration is skipped.

---
Full diff: https://github.com/llvm/llvm-project/pull/229480.diff


1 Files Affected:

- (modified) lldb/test/Shell/SymbolFile/NativePDB/thread-locals.cpp (+3-1) 


``````````diff
diff --git a/lldb/test/Shell/SymbolFile/NativePDB/thread-locals.cpp b/lldb/test/Shell/SymbolFile/NativePDB/thread-locals.cpp
index 338e3a2add978..b10dcfac77637 100644
--- a/lldb/test/Shell/SymbolFile/NativePDB/thread-locals.cpp
+++ b/lldb/test/Shell/SymbolFile/NativePDB/thread-locals.cpp
@@ -1,5 +1,7 @@
 // clang-format off
-// REQUIRES: lld, system-windows
+// FIXME: This test shouldn't require native, but it seems like the linking step
+// in the build script doesn't set the correct architecture.
+// REQUIRES: lld, system-windows, native
 
 // Test that we can display tag types.
 // RUN: %build --compiler=clang-cl --output=%t.exe %s

``````````

</details>


https://github.com/llvm/llvm-project/pull/229480