[Lldb-commits] [lldb] [lldb] Search both visionOS and XROS DeviceSupport directories (PR #228573)

[Med Ismail Bennani via lldb-commits]

================
@@ -96,19 +96,22 @@ bool PlatformDarwinDevice::UpdateSDKDirectoryInfosIfNeeded() {
     if (device_support_dir) {
       AddSharedCacheDirectory(device_support_dir, "builtin SDK directory");
 
-      // "macOS DeviceSupport", "iOS DeviceSupport", etc.
-      llvm::StringRef dirname = GetDeviceSupportDirectoryName();
-      std::string local_sdk_cache_str = "~/Library/Developer/Xcode/";
-      local_sdk_cache_str += std::string(dirname);
-      FileSpec local_sdk_cache(local_sdk_cache_str.c_str());
-      FileSystem::Instance().Resolve(local_sdk_cache);
-      if (FileSystem::Instance().Exists(local_sdk_cache)) {
-        LLDB_LOGF(log,
-                  "PlatformDarwinDevice::UpdateSDKDirectoryInfosIfNeeded "
-                  "searching %s for additional SDKs",
-                  local_sdk_cache.GetPath().c_str());
-        AddSharedCacheDirectory(local_sdk_cache.GetPath().c_str(),
-                                "system developer dir directory");
+      // "macOS DeviceSupport", "iOS DeviceSupport", etc. The names are in
----------------
medismailben wrote:

That example was there prior to my change and it represent(ed) the device support directory name for that specific platform instance, so have `// "macOS DeviceSupport", "iOS DeviceSupport", etc.` can make it look like these were returned from `GetDeviceSupportDirectoryNames`. The part that I added explains why we can stop at the first match.

https://github.com/llvm/llvm-project/pull/228573