[Lldb-commits] [lldb] d6fc996 - [lldb] Skip minidump reload test on unsupported architectures (#227634)

[via lldb-commits]

Author: Yao Qi
Date: 2026-09-30T11:22:46+01:00
New Revision: d6fc9961eb4e33e46ac4ab17b7bb1f87eacd96c4

URL: https://github.com/llvm/llvm-project/commit/d6fc9961eb4e33e46ac4ab17b7bb1f87eacd96c4
DIFF: https://github.com/llvm/llvm-project/commit/d6fc9961eb4e33e46ac4ab17b7bb1f87eacd96c4.diff

LOG: [lldb] Skip minidump reload test on unsupported architectures (#227634)

`TestMinidumpReloadCrash.py` runs `process save-core
--plugin-name=minidump` on any architecture, so it fails on 32-bit arm:

```
error: failed to save core file for process to '.../process.core':
architecture arm not supported.
```

`ArchThreadContexts::prepareRegisterContext` in
`MinidumpFileBuilder.cpp`
builds a thread context for x86_64 and aarch64 only, so `AddThreadList`
rejects any other architecture.  Gate the test like the other minidump
save-core tests.

Added: 
    

Modified: 
    lldb/test/API/functionalities/process_save_core_minidump_reload_crash/TestMinidumpReloadCrash.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/process_save_core_minidump_reload_crash/TestMinidumpReloadCrash.py b/lldb/test/API/functionalities/process_save_core_minidump_reload_crash/TestMinidumpReloadCrash.py
index 45c8143578f61..4f5e191186637 100644
--- a/lldb/test/API/functionalities/process_save_core_minidump_reload_crash/TestMinidumpReloadCrash.py
+++ b/lldb/test/API/functionalities/process_save_core_minidump_reload_crash/TestMinidumpReloadCrash.py
@@ -9,6 +9,8 @@
 
 
 class MinidumpReloadCrashTestCase(TestBase):
+    # The minidump writer only emits a thread context for x86_64 and arm64.
+    @skipIf(archs=no_match(["x86_64", "arm64", "arm64e", "aarch64"]))
     def test_reload_minidump_does_not_crash(self):
         self.build()
         target, process, thread, bkpt = lldbutil.run_to_name_breakpoint(self, "main")