[Lldb-commits] [lldb] [lldb][Windows] Re-enable tests that are not flaky with lldb-server (PR #227301)

[via lldb-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Charles Zablit (charles-zablit)

<details>
<summary>Changes</summary>

The following tests pass fine on Windows with lldb-server. Confirmed when running the tests on a machine under artificial load. Under the same load, the in-process plugin did not pass.

---
Full diff: https://github.com/llvm/llvm-project/pull/227301.diff


4 Files Affected:

- (modified) lldb/test/API/commands/process/attach-resume/TestAttachResume.py (+1-1) 
- (modified) lldb/test/API/functionalities/plugins/python_os_plugin/TestPythonOSPlugin.py (+1-1) 
- (modified) lldb/test/API/functionalities/thread/multi_break/TestMultipleBreakpoints.py (+1-1) 
- (modified) lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py (+1-1) 


``````````diff
diff --git a/lldb/test/API/commands/process/attach-resume/TestAttachResume.py b/lldb/test/API/commands/process/attach-resume/TestAttachResume.py
index dcb86543f6a0f..8225b14efbdc6 100644
--- a/lldb/test/API/commands/process/attach-resume/TestAttachResume.py
+++ b/lldb/test/API/commands/process/attach-resume/TestAttachResume.py
@@ -17,7 +17,7 @@ class AttachResumeTestCase(TestBase):
 
     @skipIfRemote
     @expectedFailureNetBSD
-    @skipIfWindows  # llvm.org/pr24778, llvm.org/pr21753
+    @skipIfWindowsAndNoLLDBServer  # llvm.org/pr24778, llvm.org/pr21753
     def test_attach_continue_interrupt_detach(self):
         """Test attach/continue/interrupt/detach"""
         self.build()
diff --git a/lldb/test/API/functionalities/plugins/python_os_plugin/TestPythonOSPlugin.py b/lldb/test/API/functionalities/plugins/python_os_plugin/TestPythonOSPlugin.py
index 6417d01529d7f..a9b24be956646 100644
--- a/lldb/test/API/functionalities/plugins/python_os_plugin/TestPythonOSPlugin.py
+++ b/lldb/test/API/functionalities/plugins/python_os_plugin/TestPythonOSPlugin.py
@@ -18,7 +18,7 @@ def test_python_os_plugin(self):
         self.build()
         self.run_python_os_funcionality()
 
-    @skipIfWindows  # This is flaky on Windows
+    @skipIfWindowsAndNoLLDBServer  # This is flaky on Windows
     def test_run_python_os_step(self):
         """Test that the Python operating system plugin works correctly when single stepping a virtual thread"""
         self.build()
diff --git a/lldb/test/API/functionalities/thread/multi_break/TestMultipleBreakpoints.py b/lldb/test/API/functionalities/thread/multi_break/TestMultipleBreakpoints.py
index d98c6d63ddc9c..86c7e3b559457 100644
--- a/lldb/test/API/functionalities/thread/multi_break/TestMultipleBreakpoints.py
+++ b/lldb/test/API/functionalities/thread/multi_break/TestMultipleBreakpoints.py
@@ -17,7 +17,7 @@ def setUp(self):
         # Find the line number for our breakpoint.
         self.breakpoint = line_number("main.cpp", "// Set breakpoint here")
 
-    @skipIfWindows  # This is flakey on Windows: llvm.org/pr24668, llvm.org/pr38373
+    @skipIfWindowsAndNoLLDBServer  # This is flakey on Windows: llvm.org/pr24668, llvm.org/pr38373
     def test(self):
         """Test simultaneous breakpoints in multiple threads."""
         self.build()
diff --git a/lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py b/lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py
index 8a21ba25347d2..82c0f1ec098af 100644
--- a/lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py
+++ b/lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py
@@ -17,7 +17,7 @@ class ThreadSpecificBreakPlusConditionTestCase(TestBase):
     # hits break in another thread in testrun
     @add_test_categories(["pyapi"])
     @expectedFlakeyNetBSD
-    @skipIfWindows  # This test is flaky on Windows
+    @skipIfWindowsAndNoLLDBServer  # This test is flaky on Windows
     def test_python(self):
         """Test that we obey thread conditioned breakpoints."""
         self.build()

``````````

</details>


https://github.com/llvm/llvm-project/pull/227301