[Lldb-commits] [lldb] b1faf8b - [lldb/test] Register xros (visionOS) as a Darwin platform (#227142)

[via lldb-commits]

Author: Med Ismail Bennani
Date: 2026-09-28T23:58:40Z
New Revision: b1faf8bc3ebbbe70daaac47a5fcd49006be3709e

URL: https://github.com/llvm/llvm-project/commit/b1faf8bc3ebbbe70daaac47a5fcd49006be3709e
DIFF: https://github.com/llvm/llvm-project/commit/b1faf8bc3ebbbe70daaac47a5fcd49006be3709e.diff

LOG: [lldb/test] Register xros (visionOS) as a Darwin platform (#227142)

`lldbplatform.py` never registered `xros` at all: no enum value, no
`__name_lookup` entry, and it was absent from `__darwin_embedded`/
`darwin_all`. As a result, `platformIsDarwin()` returned `False` for
`xros`, and `finalize_build_dictionary`'s fallback branch, which indexes
`platform_name_to_uname` by the raw platform name, would `KeyError`
before any visionOS test could build.

Add `xros` alongside the other embedded Darwin platforms so it's
recognized the same way `ios`/`tvos`/`watchos`/`bridgeos` already are.

Signed-off-by: Med Ismail Bennani <ismail at bennani.ma>

Added: 
    

Modified: 
    lldb/packages/Python/lldbsuite/test/lldbplatform.py

Removed: 
    


################################################################################
diff  --git a/lldb/packages/Python/lldbsuite/test/lldbplatform.py b/lldb/packages/Python/lldbsuite/test/lldbplatform.py
index bdde973cb6450..42e3c08bc3070 100644
--- a/lldb/packages/Python/lldbsuite/test/lldbplatform.py
+++ b/lldb/packages/Python/lldbsuite/test/lldbplatform.py
@@ -14,6 +14,7 @@
     ios,
     tvos,
     watchos,
+    xros,
     bridgeos,
     darwin_all,
     darwin_embedded,
@@ -22,10 +23,15 @@
     netbsd,
     bsd_all,
     android,
-) = range(15)
+) = range(16)
 
-__darwin_embedded = ["ios", "tvos", "watchos", "bridgeos"]
-__darwin_simulators = ["iphonesimulator", "watchsimulator", "appletvsimulator"]
+__darwin_embedded = ["ios", "tvos", "watchos", "xros", "bridgeos"]
+__darwin_simulators = [
+    "iphonesimulator",
+    "watchsimulator",
+    "appletvsimulator",
+    "xrsimulator",
+]
 
 __name_lookup = {
     windows: ["windows"],
@@ -35,6 +41,7 @@
     ios: ["ios", "iphonesimulator"],
     tvos: ["tvos", "appletvsimulator"],
     watchos: ["watchos", "watchsimulator"],
+    xros: ["xros", "xrsimulator"],
     bridgeos: ["bridgeos"],
     darwin_all: ["macosx", "darwin"] + __darwin_embedded + __darwin_simulators,
     darwin_embedded: __darwin_embedded + __darwin_simulators,