[Lldb-commits] [lldb] [lldb][test] Simplify multithreaded_queue (PR #226979)

[David Spickett via lldb-commits]

DavidSpickett wrote:

For context, my PR earlier today did fix one of the Windows on Arm issues but this remains:
```
Unresolved Tests (1):
  lldb-api :: api/multithreaded/TestMultithreaded.py
```
```
check_state: running  OK
check_state: stopped  OK
ERROR: Expected at least one frame function
Skipping the following test categories: watchpoint, libc++, libstdcxx, dwo, dsym, gmodules, debugserver, objc, fork, pexpect


--
Command Output (stderr):
--
PASS: LLDB (C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe-aarch64) :: test_breakpoint_callback (TestMultithreaded.SBBreakpointCallbackCase.test_breakpoint_callback)

SKIPPED: LLDB (C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe-aarch64) :: test_breakpoint_location_callback (TestMultithreaded.SBBreakpointCallbackCase.test_breakpoint_location_callback) (skip on windows) 

PASS: LLDB (C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe-aarch64) :: test_concurrent_unwind (TestMultithreaded.SBBreakpointCallbackCase.test_concurrent_unwind)

SKIPPED: LLDB (C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe-aarch64) :: test_python_stop_hook (TestMultithreaded.SBBreakpointCallbackCase.test_python_stop_hook) (skip on windows) 

PASS: LLDB (C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe-aarch64) :: test_sb_api_listener_event_description (TestMultithreaded.SBBreakpointCallbackCase.test_sb_api_listener_event_description)

FAIL: LLDB (C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe-aarch64) :: test_sb_api_listener_event_process_state (TestMultithreaded.SBBreakpointCallbackCase.test_sb_api_listener_event_process_state)

Log Files:

 - C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\lldb-test-build\api\multithreaded\TestMultithreaded.test_sb_api_listener_event_process_state\Error_test_sb_api_listener_event_process_state.log

PASS: LLDB (C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe-aarch64) :: test_sb_api_listener_resume (TestMultithreaded.SBBreakpointCallbackCase.test_sb_api_listener_resume)

======================================================================

ERROR: test_sb_api_listener_event_process_state (TestMultithreaded.SBBreakpointCallbackCase.test_sb_api_listener_event_process_state)

   Test that a registered SBListener receives events when a process

----------------------------------------------------------------------

Traceback (most recent call last):

  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\packages\Python\lldbsuite\test\decorators.py", line 801, in wrapper

    func(*args, **kwargs)

  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\packages\Python\lldbsuite\test\decorators.py", line 221, in wrapper

    return func(*args, **kwargs)

           ^^^^^^^^^^^^^^^^^^^^^

  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\api\multithreaded\TestMultithreaded.py", line 62, in test_sb_api_listener_event_process_state

    self.build_and_test(

  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\api\multithreaded\TestMultithreaded.py", line 118, in build_and_test

    subprocess.check_call(exe, env=env)

  File "C:\Users\tcwg\scoop\apps\python\current\Lib\subprocess.py", line 413, in check_call

    raise CalledProcessError(retcode, cmd)

subprocess.CalledProcessError: Command '['C:\\Users\\tcwg\\llvm-worker\\lldb-aarch64-windows\\build\\lldb-test-build\\api\\multithreaded\\TestMultithreaded.test_sb_api_listener_event_process_state\\test_listener_event_process_state', 'C:\\Users\\tcwg\\llvm-worker\\lldb-aarch64-windows\\build\\lldb-test-build\\api\\multithreaded\\TestMultithreaded.test_sb_api_listener_event_process_state\\inferior_program']' returned non-zero exit status 1.

Config=aarch64-C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe
```
And one way `ERROR: Expected at least one frame function` could happen is if it takes more than 5 seconds for the queue to be filled.

It would also be good to know if the queue was empty, or we timed out. I'll do that as a follow up.

https://github.com/llvm/llvm-project/pull/226979