[Lldb-commits] [lldb] ValueImpl::GetSP was calling GetError before acquiring the StopLocker. (PR #225976)

[Will Hawkins via lldb-commits]

================
@@ -480,8 +480,15 @@ class ValueObject {
   virtual bool GetDeclaration(Declaration &decl);
 
   // The functions below should NOT be modified by subclasses
+  /// Updates the ValueObject's value if needed, and then returns the
+  /// current error state.  This should only be called if the stop locker is
+  /// held so the process can't resume while this is in flight.
   const Status &GetError();
 
+  /// Return the current error without updating.  Only use this when you need
----------------
hawkinsw wrote:

```suggestion
  /// Return the current error without updating.  Only use this function when you need
```

https://github.com/llvm/llvm-project/pull/225976