[Lldb-commits] [lldb] [lldb][FreeBSDKernel] Support cross-architecture FreeBSD kernel cores (PR #224800)

[Minsoo Choo via lldb-commits]

================
@@ -551,9 +537,40 @@ lldb::addr_t ProcessFreeBSDKernelCore::FindSymbol(const char *name) {
   return sym ? sym->GetLoadAddress(&GetTarget()) : LLDB_INVALID_ADDRESS;
 }
 
+int ProcessFreeBSDKernelCore::ResolveKVMSymbol(const char *name,
+                                               kvaddr_t *value) {
+  if (!g_kvm_kernel_module)
+    return 1;
+
+  const Symbol *symbol =
+      g_kvm_kernel_module->FindFirstSymbolWithNameAndType(ConstString(name));
+  if (!symbol)
+    return 1;
+
+  lldb::addr_t address = symbol->GetFileAddress();
----------------
mchoo7 wrote:

I think getLoadAddress would be wrong here. We call this during CreateInstance and DoLoadCore, so "load" is not established yet.

https://github.com/llvm/llvm-project/pull/224800