[Lldb-commits] [lldb] [LLDB] Expose and display GDB remote register union values (PR #224147)

[Greg Clayton via lldb-commits]

================
@@ -161,6 +238,60 @@ class CommandObjectRegisterRead : public CommandObjectParsed {
     return true;
   }
 
+  bool DumpRegisterField(const ExecutionContext &exe_ctx, Stream &strm,
+                         const RegisterInfo &reg_info,
+                         llvm::StringRef expression_path,
+                         size_t reg_name_right_align_at,
+                         CommandReturnObject &result) {
+    if (!llvm::isa_and_present<RegisterTypeComposite>(reg_info.register_type)) {
+      result.AppendErrorWithFormat(
+          "Register '%s' does not have a structured type", reg_info.name);
+      return false;
+    }
+
+    StackFrame *frame = exe_ctx.GetFramePtr();
+    if (!frame)
+      return false;
+    lldb::RegisterContextSP reg_ctx_sp = frame->GetRegisterContextSP();
+    ValueObjectSP register_value =
----------------
clayborg wrote:

add `_sp` suffix to shared pointer variables, so rename to `register_value_sp`

https://github.com/llvm/llvm-project/pull/224147