[Lldb-commits] [lldb] [lldb][docs] Fix the Windows Python build options (PR #225465)

[Jonas Devlieghere via lldb-commits]

================
@@ -300,24 +309,44 @@ are commonly used on Windows.
   crashes while running the test suite. If set to 0, LLDB will silently crash.
   Setting to 1 allows a developer to attach a JIT debugger at the time of a
   crash, rather than having to reproduce a failure or use a crash dump.
-- `PYTHON_HOME` (Required): Path to the folder where the Python distribution
-  is installed. For example, `C:\Python35`.
+- `PYTHON_HOME` (Optional): Path to the folder where the Python distribution is
+  installed, used as a hint when locating Python. For example,
+  `C:\Python311`. Windows requires Python 3.11 or later.
 - `LLDB_EMBED_PYTHON_HOME` (Default=1 on Windows): When this is 1, LLDB will bind
-  statically to the location specified in the `PYTHON_HOME` CMake variable,
-  ignoring any value of `PYTHONHOME` set in the environment. This is most
-  useful for developers who simply want to run LLDB after they build it. If you
-  wish to move a build of LLDB to a different machine where Python will be in a
-  different location, setting `LLDB_EMBED_PYTHON_HOME` to 0 will cause
+  statically to the location specified in the `LLDB_PYTHON_HOME` CMake variable
+  (see below), ignoring any value of `PYTHONHOME` set in the environment. This is
+  most useful for developers who simply want to run LLDB after they build it. If
+  you wish to move a build of LLDB to a different machine where Python will be in
+  a different location, setting `LLDB_EMBED_PYTHON_HOME` to 0 will cause
   Python to use its default mechanism for finding the python installation at
   runtime (looking for installed Pythons, or using the `PYTHONHOME`
   environment variable if it is specified).
 
+  Leaving `LLDB_EMBED_PYTHON_HOME` at its Windows default also forces
----------------
JDevlieghere wrote:

'forces LLDB_ENABLE_PYTHON_LIMITED_API off' is wrong. EMBED_PYTHON_HOME only changes the option's default, it doesn't change it if it was set explicitly.

https://github.com/llvm/llvm-project/pull/225465