[Lldb-commits] [lldb] [lldb] Remove ConstString from IOHandlerCursesGUI.cpp (PR #225524)

[via lldb-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Alex Langford (bulbazord)

<details>
<summary>Changes</summary>



---
Full diff: https://github.com/llvm/llvm-project/pull/225524.diff


1 Files Affected:

- (modified) lldb/source/Core/IOHandlerCursesGUI.cpp (+5-5) 


``````````diff
diff --git a/lldb/source/Core/IOHandlerCursesGUI.cpp b/lldb/source/Core/IOHandlerCursesGUI.cpp
index 82abaeb2fba85..5f2cce04ffda4 100644
--- a/lldb/source/Core/IOHandlerCursesGUI.cpp
+++ b/lldb/source/Core/IOHandlerCursesGUI.cpp
@@ -4347,7 +4347,8 @@ class Application {
 
     ListenerSP listener_sp(
         Listener::MakeListener("lldb.IOHandler.curses.Application"));
-    ConstString broadcaster_class_process(Process::GetStaticBroadcasterClass());
+    llvm::StringRef broadcaster_class_process(
+        Process::GetStaticBroadcasterClass());
     debugger.EnableForwardEvents(listener_sp);
 
     m_update_screen = true;
@@ -4424,8 +4425,7 @@ class Application {
             if (event_sp) {
               Broadcaster *broadcaster = event_sp->GetBroadcaster();
               if (broadcaster) {
-                // uint32_t event_type = event_sp->GetType();
-                ConstString broadcaster_class(
+                llvm::StringRef broadcaster_class(
                     broadcaster->GetBroadcasterClass());
                 if (broadcaster_class == broadcaster_class_process) {
                   m_update_screen = true;
@@ -6927,9 +6927,9 @@ class SourceFileWindowDelegate : public WindowDelegate {
         m_sc = frame_sp->GetSymbolContext(eSymbolContextEverything);
         if (m_sc.module_sp) {
           m_title.Format("{0}", m_sc.module_sp->GetFileSpec().GetFilename());
-          ConstString func_name = m_sc.GetFunctionName();
+          llvm::StringRef func_name = m_sc.GetFunctionName().GetStringRef();
           if (func_name)
-            m_title.Printf("`%s", func_name.GetCString());
+            m_title.Format("`{0}", func_name);
         }
         const uint32_t frame_idx = frame_sp->GetFrameIndex();
         frame_changed = frame_idx != m_frame_idx;

``````````

</details>


https://github.com/llvm/llvm-project/pull/225524