[Lldb-commits] [lldb] [lldb] Refactor PrepareToExecuteJITExpression (PR #224888)

[via lldb-commits]

================
@@ -111,6 +111,17 @@ class LLVMUserExpression : public UserExpression {
                                        ///to the expression have been
                                        ///materialized.
   Materializer::DematerializerSP m_dematerializer_sp; ///< The dematerializer.
+
+private:
+  // Allocate the interpreter's private, host-only stack, if one has not been
+  // allocated already. Idempotent.
+  bool AllocateInterpreterStackFrame(DiagnosticManager &diagnostic_manager,
+                                     Target &target, Process *process);
+
+  // Allocate and materialize the struct.
+  bool AllocateAndMaterializeStruct(DiagnosticManager &diagnostic_manager,
----------------
jimingham wrote:

This one actually does "AllocateIfNeededButAlwaysMaterialize" which is not quite what the doc string says.

We often use IfNeeded in API's if that makes it easier to follow the logic at use sites?

https://github.com/llvm/llvm-project/pull/224888