[Lldb-commits] [lldb] 1b5da53 - [lldb-server] Fix GetMemoryRegionInfo syntax to include trailing `; ` (#224319)

[via lldb-commits]

Author: Felipe de Azevedo Piovezan
Date: 2026-09-18T08:06:01+01:00
New Revision: 1b5da535082e9f2b7bd469fbaaa1ac9aa65ba562

URL: https://github.com/llvm/llvm-project/commit/1b5da535082e9f2b7bd469fbaaa1ac9aa65ba562
DIFF: https://github.com/llvm/llvm-project/commit/1b5da535082e9f2b7bd469fbaaa1ac9aa65ba562.diff

LOG: [lldb-server] Fix GetMemoryRegionInfo syntax to include trailing `;` (#224319)

GDBRemoteCommunicationClient::GetMemoryRegionInfo parses fields of this
packet using `StringExtractor::GetNameColonValue`, which expects a `;`
even for the last field. The documentation of the packet doesn't
explicitly say so, but implies these fields should always be
;-terminated. As a result, before this patch, that field was not parsed
at all.

Added: 
    

Modified: 
    lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
index 14e2a65c63aea..516f88aaf6076 100644
--- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
@@ -3007,7 +3007,7 @@ GDBRemoteCommunicationServerLLGS::Handle_qMemoryRegionInfo(
 
     LazyBool is_stack = region_info.IsStackMemory();
     if (is_stack != eLazyBoolDontKnow)
-      response.Printf("type: %s", is_stack ? "stack" : "heap");
+      response.Printf("type:%s;", is_stack ? "stack" : "heap");
   }
 
   return SendPacketNoLock(response.GetString());