[Lldb-commits] [lldb] 123d223 - Remove ConstString from Section (#224170)

via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 17 11:10:58 PDT 2026


Author: Alex Langford
Date: 2026-09-17T11:10:42-07:00
New Revision: 123d223e8518f82684e524bf1d86b3b548328214

URL: https://github.com/llvm/llvm-project/commit/123d223e8518f82684e524bf1d86b3b548328214
DIFF: https://github.com/llvm/llvm-project/commit/123d223e8518f82684e524bf1d86b3b548328214.diff

LOG: Remove ConstString from Section (#224170)

Section names do benefit from deduplication, but most are small enough
to fit into a std::string without an allocation (i.e. SSO). We trade a
small amount of memory to avoid the cost of a ConstString
lookup/creation.

Added: 
    

Modified: 
    lldb/include/lldb/Core/Section.h
    lldb/source/Core/Section.cpp
    lldb/source/Expression/IRExecutionUnit.cpp
    lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp
    lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp
    lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
    lldb/source/Plugins/ObjectFile/JSON/ObjectFileJSON.cpp
    lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
    lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
    lldb/source/Plugins/ObjectFile/Placeholder/ObjectFilePlaceholder.cpp
    lldb/source/Plugins/ObjectFile/XCOFF/ObjectFileXCOFF.cpp
    lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp
    lldb/unittests/Symbol/JSONSymbolTest.cpp
    lldb/unittests/Symbol/SymbolTest.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/include/lldb/Core/Section.h b/lldb/include/lldb/Core/Section.h
index 5395037e7c520..70179d8f76893 100644
--- a/lldb/include/lldb/Core/Section.h
+++ b/lldb/include/lldb/Core/Section.h
@@ -10,7 +10,6 @@
 #define LLDB_CORE_SECTION_H
 
 #include "lldb/Core/ModuleChild.h"
-#include "lldb/Utility/ConstString.h"
 #include "lldb/Utility/Flags.h"
 #include "lldb/Utility/UserID.h"
 #include "lldb/lldb-defines.h"
@@ -143,7 +142,7 @@ class Section : public std::enable_shared_from_this<Section>,
 public:
   // Create a root section (one that has no parent)
   Section(const lldb::ModuleSP &module_sp, ObjectFile *obj_file,
-          lldb::user_id_t sect_id, ConstString name,
+          lldb::user_id_t sect_id, std::string name,
           lldb::SectionType sect_type, lldb::addr_t file_vm_addr,
           lldb::addr_t vm_size, lldb::offset_t file_offset,
           lldb::offset_t file_size, uint32_t log2align, uint32_t flags);
@@ -153,7 +152,7 @@ class Section : public std::enable_shared_from_this<Section>,
                                                     // sections, non-NULL for
                                                     // child sections
           const lldb::ModuleSP &module_sp, ObjectFile *obj_file,
-          lldb::user_id_t sect_id, ConstString name,
+          lldb::user_id_t sect_id, std::string name,
           lldb::SectionType sect_type, lldb::addr_t file_vm_addr,
           lldb::addr_t vm_size, lldb::offset_t file_offset,
           lldb::offset_t file_size, uint32_t log2align, uint32_t flags);
@@ -289,7 +288,7 @@ class Section : public std::enable_shared_from_this<Section>,
                             // be read from
   lldb::SectionType m_type; // The type of this section
   lldb::SectionWP m_parent_wp; // Weak pointer to parent section
-  ConstString m_name;          // Name of this section
+  std::string m_name;          // Name of this section
   lldb::addr_t m_file_addr; // The absolute file virtual address range of this
                             // section if m_parent == NULL,
   // offset from parent file virtual address if m_parent != NULL

diff  --git a/lldb/source/Core/Section.cpp b/lldb/source/Core/Section.cpp
index 90b561f02db6b..ab0ecd352b507 100644
--- a/lldb/source/Core/Section.cpp
+++ b/lldb/source/Core/Section.cpp
@@ -162,12 +162,12 @@ const char *Section::GetTypeAsCString() const {
 }
 
 Section::Section(const ModuleSP &module_sp, ObjectFile *obj_file,
-                 user_id_t sect_id, ConstString name, SectionType sect_type,
+                 user_id_t sect_id, std::string name, SectionType sect_type,
                  addr_t file_addr, addr_t byte_size, lldb::offset_t file_offset,
                  lldb::offset_t file_size, uint32_t log2align, uint32_t flags)
     : ModuleChild(module_sp), UserID(sect_id), Flags(flags),
-      m_obj_file(obj_file), m_type(sect_type), m_parent_wp(), m_name(name),
-      m_file_addr(file_addr), m_byte_size(byte_size),
+      m_obj_file(obj_file), m_type(sect_type), m_parent_wp(),
+      m_name(std::move(name)), m_file_addr(file_addr), m_byte_size(byte_size),
       m_file_offset(file_offset), m_file_size(file_size),
       m_log2align(log2align), m_children(), m_fake(false), m_encrypted(false),
       m_thread_specific(false), m_readable(false), m_writable(false),
@@ -175,12 +175,12 @@ Section::Section(const ModuleSP &module_sp, ObjectFile *obj_file,
 
 Section::Section(const lldb::SectionSP &parent_section_sp,
                  const ModuleSP &module_sp, ObjectFile *obj_file,
-                 user_id_t sect_id, ConstString name, SectionType sect_type,
+                 user_id_t sect_id, std::string name, SectionType sect_type,
                  addr_t file_addr, addr_t byte_size, lldb::offset_t file_offset,
                  lldb::offset_t file_size, uint32_t log2align, uint32_t flags)
     : ModuleChild(module_sp), UserID(sect_id), Flags(flags),
-      m_obj_file(obj_file), m_type(sect_type), m_parent_wp(), m_name(name),
-      m_file_addr(file_addr), m_byte_size(byte_size),
+      m_obj_file(obj_file), m_type(sect_type), m_parent_wp(),
+      m_name(std::move(name)), m_file_addr(file_addr), m_byte_size(byte_size),
       m_file_offset(file_offset), m_file_size(file_size),
       m_log2align(log2align), m_children(), m_fake(false), m_encrypted(false),
       m_thread_specific(false), m_readable(false), m_writable(false),

diff  --git a/lldb/source/Expression/IRExecutionUnit.cpp b/lldb/source/Expression/IRExecutionUnit.cpp
index fe0c060184c6d..abc61865cb6d8 100644
--- a/lldb/source/Expression/IRExecutionUnit.cpp
+++ b/lldb/source/Expression/IRExecutionUnit.cpp
@@ -1229,15 +1229,14 @@ void IRExecutionUnit::PopulateSectionList(
     lldb_private::SectionList &section_list) {
   for (AllocationRecord &record : m_records) {
     if (record.m_size > 0) {
-      lldb::SectionSP section_sp(new lldb_private::Section(
-          obj_file->GetModule(), obj_file, record.m_section_id,
-          ConstString(record.m_name), record.m_sect_type,
-          record.m_process_address, record.m_size,
+      lldb::SectionSP section_sp = std::make_shared<Section>(
+          obj_file->GetModule(), obj_file, record.m_section_id, record.m_name,
+          record.m_sect_type, record.m_process_address, record.m_size,
           record.m_host_address, // file_offset (which is the host address for
                                  // the data)
           record.m_size,         // file_size
           0,
-          record.m_permissions)); // flags
+          record.m_permissions); // flags
       section_list.AddSection(section_sp);
     }
   }

diff  --git a/lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp b/lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp
index 9433f834b7f05..7d79d938723e2 100644
--- a/lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp
+++ b/lldb/source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp
@@ -157,8 +157,8 @@ void ObjectFileBreakpad::CreateSections(SectionList &unified_section_list) {
 
     offset_t end_offset = end_ptr - m_data_nsp->GetDataStart();
     auto section_sp = std::make_shared<Section>(
-        GetModule(), this, next_section_id++,
-        ConstString(toString(*current_section)), eSectionTypeOther,
+        GetModule(), this, next_section_id++, toString(*current_section).str(),
+        eSectionTypeOther,
         /*file_vm_addr*/ 0, /*vm_size*/ 0, section_start,
         end_offset - section_start, /*log2align*/ 0, /*flags*/ 0);
     m_sections_up->AddSection(section_sp);

diff  --git a/lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp b/lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp
index 79eaa5da647a1..505ce8391d193 100644
--- a/lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp
+++ b/lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp
@@ -252,17 +252,12 @@ void ObjectFileCOFF::CreateSections(lldb_private::SectionList &sections) {
     if (!Name)
       consumeError(Name.takeError());
 
-    SectionSP section =
-        std::make_unique<Section>(module, this,
-                                  static_cast<user_id_t>(SecRef.getIndex()),
-                                  ConstString(SectionName),
-                                  SectionType(SectionName, COFFSection),
-                                  COFFSection->VirtualAddress,
-                                  COFFSection->VirtualSize,
-                                  COFFSection->PointerToRawData,
-                                  COFFSection->SizeOfRawData,
-                                  COFFSection->getAlignment(),
-                                  0);
+    SectionSP section = std::make_unique<Section>(
+        module, this, static_cast<user_id_t>(SecRef.getIndex()),
+        SectionName.str(), SectionType(SectionName, COFFSection),
+        COFFSection->VirtualAddress, COFFSection->VirtualSize,
+        COFFSection->PointerToRawData, COFFSection->SizeOfRawData,
+        COFFSection->getAlignment(), 0);
     section->SetPermissions(Permissions(COFFSection));
 
     m_sections_up->AddSection(section);

diff  --git a/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp b/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
index 255280d1f021a..3dd1f0801cc62 100644
--- a/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
+++ b/lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
@@ -2147,7 +2147,7 @@ void ObjectFileELF::CreateSections(SectionList &unified_section_list) {
     uint32_t Log2Align = llvm::Log2_64(std::max<elf_xword>(PHdr.p_align, 1));
     SectionSP Segment = std::make_shared<Section>(
         GetModule(), this, SegmentID(EnumPHdr.index()),
-        ConstString(provider.GetNextSegmentName()), eSectionTypeContainer,
+        provider.GetNextSegmentName(), eSectionTypeContainer,
         InfoOr->GetRangeBase(), InfoOr->GetByteSize(), PHdr.p_offset,
         PHdr.p_filesz, Log2Align, /*flags*/ 0);
     Segment->SetPermissions(GetPermissions(PHdr));
@@ -2185,8 +2185,8 @@ void ObjectFileELF::CreateSections(SectionList &unified_section_list) {
         this,            // ObjectFile to which this section belongs and should
                          // read section data from.
         SectionIndex(I), // Section ID.
-        ConstString(name),            // Section name.
-        sect_type,                    // Section type.
+        name,            // Section name.
+        sect_type,       // Section type.
         InfoOr->Range.GetRangeBase(), // VM address.
         InfoOr->Range.GetByteSize(),  // VM size in bytes of this section.
         header.sh_offset,             // Offset of this section in the file.

diff  --git a/lldb/source/Plugins/ObjectFile/JSON/ObjectFileJSON.cpp b/lldb/source/Plugins/ObjectFile/JSON/ObjectFileJSON.cpp
index c6fe82916301f..a1fd4af85a51c 100644
--- a/lldb/source/Plugins/ObjectFile/JSON/ObjectFileJSON.cpp
+++ b/lldb/source/Plugins/ObjectFile/JSON/ObjectFileJSON.cpp
@@ -205,7 +205,7 @@ void ObjectFileJSON::CreateSections(SectionList &unified_section_list) {
       auto sect_id = section.user_id.value_or(id + 1);
       if (!section.user_id.has_value())
         ++id;
-      const auto name = ConstString(section.name);
+      const auto name = section.name;
       const auto sect_type = section.type.value_or(eSectionTypeCode);
       const auto vm_addr = section.address.value_or(0);
       const auto vm_size = section.size.value_or(0);

diff  --git a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
index ab73da8471937..344665867185e 100644
--- a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
+++ b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
@@ -1660,7 +1660,7 @@ void ObjectFileMachO::ProcessSegmentCommand(
             << 8, // Section ID is the 1 based segment index
         // shifted right by 8 bits as not to collide with any of the 256
         // section IDs that are possible
-        ConstString(segname),  // Name of this section
+        segname.str(),         // Name of this section
         eSectionTypeContainer, // This section is a container of other
         // sections.
         load_cmd.vmaddr, // File VM address == addresses as they are
@@ -1824,7 +1824,7 @@ void ObjectFileMachO::ProcessSegmentCommand(
               // shifted right by 8 bits as not to
               // collide with any of the 256 section IDs
               // that are possible
-              ConstString(segname),  // Name of this section
+              segname.str(),         // Name of this section
               eSectionTypeContainer, // This section is a container of
               // other sections.
               sect64.addr, // File VM address == addresses as they are
@@ -1851,7 +1851,7 @@ void ObjectFileMachO::ProcessSegmentCommand(
 
       SectionSP section_sp = std::make_shared<Section>(
           segment_sp, module_sp, this, ++context.NextSectionIdx,
-          ConstString(section_name), sect_type,
+          section_name.str(), sect_type,
           sect64.addr - segment_sp->GetFileAddress(), sect64.size,
           section_file_offset, section_file_offset == 0 ? 0 : sect64.size,
           sect64.align, sect64.flags);

diff  --git a/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp b/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
index e71c2a7579084..cb69b9881a514 100644
--- a/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
+++ b/lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
@@ -1040,9 +1040,8 @@ void ObjectFilePECOFF::CreateSections(SectionList &unified_section_list) {
     std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
 
     SectionSP header_sp = std::make_shared<Section>(
-        module_sp, this, ~user_id_t(0), ConstString("PECOFF header"),
-        eSectionTypeOther, m_coff_header_opt.image_base,
-        m_coff_header_opt.header_size,
+        module_sp, this, ~user_id_t(0), "PECOFF header", eSectionTypeOther,
+        m_coff_header_opt.image_base, m_coff_header_opt.header_size,
         /*file_offset*/ 0, m_coff_header_opt.header_size,
         m_coff_header_opt.sect_alignment,
         /*flags*/ 0);
@@ -1053,14 +1052,13 @@ void ObjectFilePECOFF::CreateSections(SectionList &unified_section_list) {
     const uint32_t nsects = m_sect_headers.size();
     for (uint32_t idx = 0; idx < nsects; ++idx) {
       llvm::StringRef sect_name = GetSectionName(m_sect_headers[idx]);
-      ConstString const_sect_name(sect_name);
       SectionType section_type = GetSectionType(sect_name, m_sect_headers[idx]);
 
       SectionSP section_sp = std::make_shared<Section>(
           module_sp,       // Module to which this section belongs
           this,            // Object file to which this section belongs
           idx + 1,         // Section ID is the 1 based section index.
-          const_sect_name, // Name of this section
+          sect_name.str(), // Name of this section
           section_type,
           m_coff_header_opt.image_base +
               m_sect_headers[idx].vmaddr, // File VM address == addresses as

diff  --git a/lldb/source/Plugins/ObjectFile/Placeholder/ObjectFilePlaceholder.cpp b/lldb/source/Plugins/ObjectFile/Placeholder/ObjectFilePlaceholder.cpp
index e8745d6dd6b83..4dd5c1bd29648 100644
--- a/lldb/source/Plugins/ObjectFile/Placeholder/ObjectFilePlaceholder.cpp
+++ b/lldb/source/Plugins/ObjectFile/Placeholder/ObjectFilePlaceholder.cpp
@@ -37,9 +37,8 @@ void ObjectFilePlaceholder::CreateSections(
     lldb_private::SectionList &unified_section_list) {
   m_sections_up = std::make_unique<lldb_private::SectionList>();
   auto section_sp = std::make_shared<lldb_private::Section>(
-      GetModule(), this, /*sect_id*/ 0,
-      lldb_private::ConstString(".module_image"), eSectionTypeOther, m_base,
-      m_size, /*file_offset*/ 0, /*file_size*/ 0,
+      GetModule(), this, /*sect_id*/ 0, ".module_image", eSectionTypeOther,
+      m_base, m_size, /*file_offset*/ 0, /*file_size*/ 0,
       /*log2align*/ 0, /*flags*/ 0);
   section_sp->SetPermissions(ePermissionsReadable | ePermissionsExecutable);
   m_sections_up->AddSection(section_sp);

diff  --git a/lldb/source/Plugins/ObjectFile/XCOFF/ObjectFileXCOFF.cpp b/lldb/source/Plugins/ObjectFile/XCOFF/ObjectFileXCOFF.cpp
index 1ecf27ff3d5c0..a00d92f588520 100644
--- a/lldb/source/Plugins/ObjectFile/XCOFF/ObjectFileXCOFF.cpp
+++ b/lldb/source/Plugins/ObjectFile/XCOFF/ObjectFileXCOFF.cpp
@@ -322,8 +322,6 @@ void ObjectFileXCOFF::CreateSectionsWithBitness(
   for (const typename T::SectionHeader &section :
        GetSections<T>(m_binary.get())) {
 
-    ConstString const_sect_name(section.Name);
-
     SectionType section_type = lldb::eSectionTypeOther;
     if (section.Flags & XCOFF::STYP_TEXT)
       section_type = eSectionTypeCode;
@@ -341,7 +339,7 @@ void ObjectFileXCOFF::CreateSectionsWithBitness(
     }
 
     SectionSP section_sp = std::make_shared<Section>(
-        module_sp, this, ++idx, const_sect_name, section_type,
+        module_sp, this, ++idx, section.Name, section_type,
         section.VirtualAddress, section.SectionSize,
         section.FileOffsetToRawData, section.SectionSize, 0, section.Flags);
 

diff  --git a/lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp b/lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp
index 0e20c8d2c73ae..cb7e04c1925b6 100644
--- a/lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp
+++ b/lldb/source/Plugins/ObjectFile/wasm/ObjectFileWasm.cpp
@@ -839,18 +839,18 @@ void ObjectFileWasm::CreateSections(SectionList &unified_section_list) {
     }
 
     SectionSP section_sp = std::make_shared<Section>(
-        GetModule(),  // Module to which this section belongs.
-        this,         // ObjectFile to which this section belongs and
-                      // should read section data from.
-        section_type, // Section ID.
-        ConstString(section_name), // Section name.
-        section_type,              // Section type.
-        vm_addr,                   // VM address.
-        vm_size,                   // VM size in bytes of this section.
-        file_offset,               // Offset of this section in the file.
-        sect_info.size,            // Size of the section as found in the file.
-        0,                         // Alignment of the section
-        0);                        // Flags for this section.
+        GetModule(),    // Module to which this section belongs.
+        this,           // ObjectFile to which this section belongs and
+                        // should read section data from.
+        section_type,   // Section ID.
+        section_name,   // Section name.
+        section_type,   // Section type.
+        vm_addr,        // VM address.
+        vm_size,        // VM size in bytes of this section.
+        file_offset,    // Offset of this section in the file.
+        sect_info.size, // Size of the section as found in the file.
+        0,              // Alignment of the section
+        0);             // Flags for this section.
     m_sections_up->AddSection(section_sp);
     unified_section_list.AddSection(section_sp);
   }
@@ -924,7 +924,7 @@ void ObjectFileWasm::CreateSections(SectionList &unified_section_list) {
   if (!m_globals.empty()) {
     global_section_sp = std::make_shared<Section>(
         GetModule(),
-        /*obj_file=*/this, eSectionTypeWasmGlobal, ConstString("global"),
+        /*obj_file=*/this, eSectionTypeWasmGlobal, "global",
         eSectionTypeWasmGlobal,
         /*file_vm_addr=*/kWasmGlobalFileAddress,
         /*vm_size=*/m_num_imported_globals + m_globals.size(),
@@ -979,7 +979,7 @@ void ObjectFileWasm::CreateSections(SectionList &unified_section_list) {
         /*obj_file=*/this,
         ++segment_id << 8, // 1-based segment index, shifted by 8 bits to avoid
                            // collision with section IDs.
-        ConstString(segment.name), GetSegmentTypeFromName(segment.name),
+        segment.name, GetSegmentTypeFromName(segment.name),
         /*file_vm_addr=*/file_vm_addr,
         /*vm_size=*/segment.size,
         /*file_offset=*/file_offset,
@@ -1005,15 +1005,14 @@ void ObjectFileWasm::CreateSections(SectionList &unified_section_list) {
       LLDB_LOG_ERROR(log, memory_size.takeError(),
                      "Failed to parse Wasm memory section: {0}");
     } else if (*memory_size > static_data_end) {
-      SectionSP bss_sp =
-          std::make_shared<Section>(GetModule(),
-                                    /*obj_file=*/this, ++segment_id << 8,
-                                    ConstString(".bss"), eSectionTypeZeroFill,
-                                    /*file_vm_addr=*/static_data_end,
-                                    /*vm_size=*/*memory_size - static_data_end,
-                                    /*file_offset=*/0,
-                                    /*file_size=*/0,
-                                    /*log2align=*/0, /*flags=*/0);
+      SectionSP bss_sp = std::make_shared<Section>(
+          GetModule(),
+          /*obj_file=*/this, ++segment_id << 8, ".bss", eSectionTypeZeroFill,
+          /*file_vm_addr=*/static_data_end,
+          /*vm_size=*/*memory_size - static_data_end,
+          /*file_offset=*/0,
+          /*file_size=*/0,
+          /*log2align=*/0, /*flags=*/0);
       m_sections_up->AddSection(bss_sp);
       GetModule()->GetSectionList()->AddSection(bss_sp);
     }

diff  --git a/lldb/unittests/Symbol/JSONSymbolTest.cpp b/lldb/unittests/Symbol/JSONSymbolTest.cpp
index 9fc035b4ff2ce..e0341d02961bf 100644
--- a/lldb/unittests/Symbol/JSONSymbolTest.cpp
+++ b/lldb/unittests/Symbol/JSONSymbolTest.cpp
@@ -42,7 +42,7 @@ TEST(JSONSymbolTest, DeserializeCodeAddress) {
       /*module_sp=*/ModuleSP(),
       /*obj_file=*/nullptr,
       /*sect_id=*/1,
-      /*name=*/ConstString(".text"),
+      /*name=*/".text",
       /*sect_type=*/eSectionTypeCode,
       /*file_vm_addr=*/0x1000,
       /*vm_size=*/0x1000,
@@ -175,7 +175,7 @@ TEST(JSONSymbolTest, SymbolInvalidAddressNotInSection) {
       /*module_sp=*/ModuleSP(),
       /*obj_file=*/nullptr,
       /*sect_id=*/1,
-      /*name=*/ConstString(".text"),
+      /*name=*/".text",
       /*sect_type=*/eSectionTypeCode,
       /*file_vm_addr=*/0x1000,
       /*vm_size=*/0x1000,

diff  --git a/lldb/unittests/Symbol/SymbolTest.cpp b/lldb/unittests/Symbol/SymbolTest.cpp
index 3e67a01a81f64..d019e993f0236 100644
--- a/lldb/unittests/Symbol/SymbolTest.cpp
+++ b/lldb/unittests/Symbol/SymbolTest.cpp
@@ -52,7 +52,7 @@ TEST(SymbolTest, EncodeDecodeSymbol) {
       /*module_sp=*/ModuleSP(),
       /*obj_file=*/nullptr,
       /*sect_id=*/1,
-      /*name=*/ConstString(".text"),
+      /*name=*/".text",
       /*sect_type=*/eSectionTypeCode,
       /*file_vm_addr=*/0x1000,
       /*vm_size=*/0x1000,


        


More information about the lldb-commits mailing list